Skip to content

Commit

Permalink
chore(deps): Bundle ginkgo updates
Browse files Browse the repository at this point in the history
Problem

Due to updates to ginkgo CLI version specified in `.tool-versions`
and the `ginkgo` Go library version being in different update PRs,
we saw warnings like:

```
Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.16.0
  Mismatched package versions found:
    2.17.0 used by integration
```

Solution

Bundle the update for both in one PR in `renovate` and disable
`dependabot` PRs as we anyways rely on `renovate`.

To ensure that `ginkgo` CLI and library versions do not diverge,
  • Loading branch information
silvestre committed Mar 25, 2024
1 parent 7414a9a commit e8446b3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 73 deletions.
73 changes: 0 additions & 73 deletions .github/dependabot.yaml

This file was deleted.

8 changes: 8 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@
"description": "Strip of v prefix from version number in certain github releases",
"matchPackageNames": ["bosh-cli"],
"extractVersion": "^v(?<version>.*)$"
},
{
"description": "Group Ginkgo CLI and library updates together",
"groupName": "ginkgo updates",
"matchPackagePatterns": [
"^github.com/onsi/ginkgo$",
"^github.com/onsi/ginkgo/v2$"
]
}
],
"nix": {"enabled": true},
Expand Down

0 comments on commit e8446b3

Please sign in to comment.