not to unclaim a claimed lrp #119
Draft
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
kart2bc
force-pushed
the
lrp-claim
branch
2 times, most recently
from
49f479e to
9c3ec5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Converge loop attempts to unclaim the stale lrps. However, if that lrp is claimed by another cell, then it should not change the status.
bbs/db/sqldb/lrp_convergence.go
Line 97 in d1ca598
The above method only looks for an unclaimed lrp which sits for 30 sec.
It is added to the unstartedkeys list and goes for the next auction. In b/w if it is claimed by any other cell the state changes to claimed and we can preserve that state.
Backward Compatibility
Breaking Change? No