Bump to gopkg.in/yaml.v2 to v3 in the release/manifest package #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating to v3 does make changes to Marshaling but Unmarshal should behave the same
crhntr
changed the title
rkoster
requested review from
a team,
ragaskar and
ystros
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
By merging this, we can bump the bosh-cli dependency and then th bosh-agent no longer need to import yaml.v2.
It will also make the following CVE scan results go away: https://pkg.go.dev/search?q=gopkg.in%2Fyaml.v2&m=vuln
Notes
Updating to v3 does make changes to encoding but decoding should behave close enough to v2 for this package's use.