Skip to content

Commit

Permalink
Bump to v2 of the Ginkgo CLI
Browse files Browse the repository at this point in the history
- Keep in sync with cf-acceptance-tests.
- Update the run-cats tasks to use the new v2 CLI flags (kebab case
  intsead of camel case).
- Update the default slow spec threshold param to be a Golang time
  duration, instead of a number of seconds.
  • Loading branch information
davewalter committed Jul 7, 2022
1 parent a50cb11 commit fdf91b7
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion dockerfiles/cf-deployment-concourse-tasks/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ RUN \

RUN \
go install github.com/cloudfoundry/uptimer@${uptimer_version} && \
go install github.com/onsi/ginkgo/...
go install github.com/onsi/ginkgo/v2/ginkgo@latest

# Add trusted relint ca certificate
ARG RELINT_CA_CERTIFICATE
Expand Down
11 changes: 5 additions & 6 deletions run-cats/task
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,10 @@ export CF_DIAL_TIMEOUT=11
export CF_PLUGIN_HOME=$HOME

./bin/test \
-keepGoing \
-randomizeAllSpecs \
-skipPackage=helpers \
-slowSpecThreshold="${SLOW_SPEC_THRESHOLD}" \
-keep-going \
-randomize-all \
-skip-package=helpers \
-slow-spec-shreshold="${SLOW_SPEC_THRESHOLD}" \
-nodes="${NODES}" \
-skip="${SKIP_REGEXP}" \
-flakeAttempts=${FLAKE_ATTEMPTS} \
-noisySkippings=false
-flake-attempts=${FLAKE_ATTEMPTS}
4 changes: 2 additions & 2 deletions run-cats/task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ run:
path: cf-deployment-concourse-tasks/run-cats/task

params:
SLOW_SPEC_THRESHOLD: 315
SLOW_SPEC_THRESHOLD: 315s
# - Optional
# - The amount of time, in seconds, to wait before marking a test as slow.
# - The amount of time, as a Golang time.Duration, to wait before marking a test as slow.

NODES: 12
# - Optional
Expand Down

0 comments on commit fdf91b7

Please sign in to comment.