Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find the right place for bosh-package-java-release and bosh-package-cf-cli-release #653

Conversation

beyhan
Copy link
Member

@beyhan beyhan commented Jul 21, 2023

With Consolidate bosh-packages and bosh-io into cloudfoundry github org the FI WG got two repositories which don't really belong to the WG. This pr suggests a possible move but our intention is to start a discussion to find right place for them. cc @rkoster & @jpalermo

…f-cli-release

With [Consolidate bosh-packages and bosh-io into cloudfoundry github
org](#512) the FI WG
got two repositories which don't really belong to the WG. This pr
suggests a possible move but our intetion is to start a discussion
to find right place for them.
@rkoster rkoster requested a review from jpalermo July 27, 2023 14:58
@jpalermo
Copy link
Member

Seems good to me, but it would also be good to have somebody from those WGs weigh in too.

@beyhan
Copy link
Member Author

beyhan commented Jul 28, 2023

@dmikusa or @anthonydahanne could you please comment regarding the move of cloudfoundry/bosh-package-java-release?

@reedr3 or @a-b could you please comment regarding the move of cloudfoundry/bosh-package-cf-cli-release?

@beyhan beyhan added the wg label Aug 1, 2023
@@ -117,6 +117,7 @@ areas:
- cloudfoundry/java-buildpack-system-test
- cloudfoundry/java-test-applications
- cloudfoundry/jvmkill
- cloudfoundry/bosh-package-java-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bosh-package-cf-cli-release LGTM

@Gerg
Copy link
Member

Gerg commented Aug 14, 2023

Adding @pivotal-david-osullivan for cloudfoundry/bosh-package-java-release

@Gerg
Copy link
Member

Gerg commented Aug 16, 2023

@beyhan @rkoster What is the rationale for moving bosh-package-java-release out of FI, but not the other language packages (package-ruby-release, package-golang-release, etc)?

@rkoster
Copy link
Contributor

rkoster commented Aug 17, 2023

The java package according to bosh.io is only being used by the autoscaler: https://github.com/cloudfoundry/app-autoscaler-release/tree/main/packages/openjdk-17

Maybe it would be more appropriate to move it into the Autoscaler area.

@Gerg
Copy link
Member

Gerg commented Aug 17, 2023

Right, but what is the reason for moving some of the bosh-package-* releases out of FI?

Why is bosh-package-ruby-release staying in FI? Just because BOSH uses it?

Why is bosh-package-python-release, for instance, staying in FI?

What if another release wants to start using bosh-package-java-release?

@jpalermo
Copy link
Member

We certainly know that FI has no expertise with the java package or bosh releases using java or how these packages should be built.

It would be good to have an owner that has a vested interest in it, but maybe that doesn't exist...

@rkoster
Copy link
Contributor

rkoster commented Aug 24, 2023

The alternative is to archive bosh-package-java-release, given that we have no approvers in the FI working group who have context on this release (UAA & Credhub do not use it).

@Gerg
Copy link
Member

Gerg commented Sep 6, 2023

What is the history for why that package was introduced in the first place? Just for language completeness?

@beyhan
Copy link
Member Author

beyhan commented Sep 14, 2023

I don't the history. @jpalermo, @rkoster do you know?

@jpalermo
Copy link
Member

Don't have the full history, but based on some old tracker stories (with virtually zero details), the commit history, and some wild speculation; my guess would be it was created because we were doing it for other languages and we had at least one bosh release using Java.

@Gerg
Copy link
Member

Gerg commented Sep 14, 2023

we had at least one bosh release using Java

Which release was it? Or are you talking about UAA/Credhub using Java in general (but not the bosh package)?

@jpalermo
Copy link
Member

Looks like UAA/Credhub have never used it. It was used by a closed source release from 2018 to 2020, and then app autoscaler has been using it since 2022.

2018 isn't TOO far off from when it was created, but it was ~9 months after.

So my guess is it was created because we had some Java releases, primarily UAA/Credhub, and they never adopted it.

@beyhan
Copy link
Member Author

beyhan commented Sep 15, 2023

I would suggest then to archive the bosh-package-java-release.

@jpalermo
Copy link
Member

If we did want to archive it, we'd need to give app-autoscaler-release a chance to move off of it first.

@Gerg
Copy link
Member

Gerg commented Sep 16, 2023

Should we consider transferring ownership to the ARI Autoscaler area then?

@beyhan
Copy link
Member Author

beyhan commented Sep 18, 2023

Hi @silvestre,

With the implementation of #512 the FI WG got the bosh-package-java-release repository which is not used in the FI WG and we don't have expertise to maintain this repository. It looks like the ARI Autoscaler area is the only use of this repository. Do want to take ownership of this repository? The alternative is to archive it.

@silvestre
Copy link
Member

Hi @beyhan, @Gerg,

thanks for reaching out!

As app-autoscaler-release is the only user, I don't think it makes sense for us to maintain this but we will switch back to packaging Java ourselves.

Feel free to archive it at any time.

beyhan added a commit that referenced this pull request Sep 18, 2023
Based on the discussions in #653
the decision was taken to maintain this repository. The only user
of it is the ARI WG App Autoscaler Area but they are in favor to [package
Java themself](#653 (comment)) instead of maintaining this repopository
beyhan added a commit that referenced this pull request Sep 18, 2023
Based on the discussions in #653 the decision was taken to
archive the `bosh-package-java-release` repository. The only user of it is the App Autoscaler Area from
the ARI WG but they are in favour to [package Java themself](#653 (comment)) instead of maintaining `bosh-package-java-release` repository.
@beyhan
Copy link
Member Author

beyhan commented Sep 18, 2023

Thanks @silvestre for the response. Based on the discussion I open #687 to archive bosh-package-java-release. I will close this pr because it includes more things than just the bosh-package-java-release.

@beyhan beyhan closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants