Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approver blora to Docs approvers #673

Closed
wants to merge 6 commits into from

Conversation

blora1
Copy link
Contributor

@blora1 blora1 commented Aug 21, 2023

I am a new docs writer from VMware and am requesting to become an approver for all docs areas.

This affects 3 working groups and requires approval from the tech leads in each working group:

blora1 and others added 5 commits August 21, 2023 10:56
I am a new docs writer from VMware and am requesting to become an approver for all docs areas.

This affects 3 working groups and requires approval from the tech leads in each working group:
* App Runtime Platform - @ameowlia
* App Runtime Interfaces - @Gerg
* Foundational Infrastructure - @beyhan and/or @rkoster
Merge remote-tracking branch
'origin/add-approver-blora-2' into add-approver-blora
@@ -68,6 +68,8 @@ areas:
github: snneji
- name: Ben Klein
github: fifthposition
- name: Lora Boe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Stephan. I updated the indentation.

Copy link
Contributor

@stephanme stephanme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically ok and validation passes. WG leads still need to approve.

@ameowlia
Copy link
Member

I approve! And I will ping the other leads on slack.

@ChrisMcGowan ChrisMcGowan self-requested a review August 28, 2023 11:01
@ameowlia
Copy link
Member

we made a new docs WG instead! #677

@ameowlia ameowlia closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants