New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Michael Oleske to CLI approver #680

Merged

ameowlia merged 1 commit into cloudfoundry:main from a-b:patch-4

Dec 4, 2023

Member

a-b commented Sep 12, 2023

For many years, Michael made valuable contributions to the CLI. I trust Michaels's judgment and am confident he has sufficient expertise to decide what suits this project.


          Promote Michael Oleske to CLI approver

3b3f6f0

For many years, Michael made valuable contributions to the CLI. I trust Michaels's judgment and am confident he has sufficient expertise to decide what suits this project.

Gerg self-requested a review

September 12, 2023 22:30

Member

beyhan commented Sep 14, 2023

According to the promotion rules one approval is enough in this case because the CLI areas has less than 4 approvers. @reedr3 or @jdgonzaleza could one of you attest by a comment this promotion.

beyhan added the wg label

Member

beyhan commented Nov 17, 2023

ping @reedr3 , @ccjaimes ^

Member

beyhan commented Nov 17, 2023

For the records the contributions done by @moleske to the CLI are (generated by using the contributions-for-user.sh script):

App Runtime Interfaces: CLI Contributions

PRs Commented on/Reviewed:

2023-10-12T23:50:54Z: Add --wait, -w flag to run-task
2023-10-20T17:51:49Z: Promote changes from develop to the master branch

Issues that may be relevant:

2022-06-16T22:24:07Z: Update Contributing to use go 1.18
2022-09-15T23:17:55Z: Use jq instead of grep -P for finding users to delete during integrat…
2022-09-16T19:27:42Z: Allow user to rename app if buildpack is deleted
2022-09-22T16:30:19Z: Use Eventually/Should for routes_command list routes with http1 and
2022-10-13T20:34:12Z: Replace ioutil.ReadFile with embed for fixtures
2022-10-13T21:06:29Z: Explicity enable route_sharing feature on tests that need it
2022-10-13T22:39:54Z: Use default of 1GB memory instead of 32M
2022-10-19T23:24:52Z: Add Isolation Segment
2022-10-20T22:41:28Z: Add OIDC to GitHub Integration Actions
2023-02-03T18:19:41Z: Allow Stack Auditor plugin to work with cf cli 7 and 8
2023-02-25T00:32:41Z: Get to ginkgo v2
2023-03-17T18:05:20Z: Add github actions to test prs
2023-03-17T18:29:06Z: Add dependabot to keep up to date
2023-05-05T13:39:19Z: If changing the stack fails app state is not restored
2023-05-05T22:19:39Z: Remove ubuntu 18.04 and macos-10.15 from unit tests
2023-05-05T23:28:31Z: Use specific ruby buildpack for does_not_stage_on_fs4 app
2023-06-14T22:52:28Z: Bump code.cloudfoundry.org/lager from 1.1.1-0.20191008172124-a9afc05ee5be to 2.0.0+incompatible
2023-08-18T22:24:20Z: Bump depedencies and fix race condition in v7
2023-08-18T23:16:22Z: turn on dependabot for branches v7 and v8 in support
2023-08-24T21:10:53Z: Bump github.com/docker/distribution to 2.8.2
2023-08-24T21:17:48Z: bump github.com/docker/distribution to 2.8.2
2023-08-25T17:05:07Z: keep github actions up to date
2023-08-25T17:57:53Z: Add use latest ruby-buildpack for when we test with older cf-deployments
2023-08-25T18:11:24Z: Use latest ruby buildpack v7
2023-08-25T18:14:20Z: Use latest ruby buildpack for min capi tests v8
2023-08-25T18:15:31Z: Use latest ruby buildpack for min capi tests main
2023-08-26T02:22:06Z: Bump actions/download-artifact from 2 to 3
2023-08-29T23:35:08Z: add 8.7.2 release
2023-08-30T22:43:44Z: add 7.7.2 release
2023-08-30T22:45:14Z: add 7.7.2 release
2023-08-31T19:52:21Z: Update release pipeline to fix old concourse resources not supporting aws role arn
2023-09-01T22:26:10Z: Remove unneeded replace gopkg.in/fsnotify.v1
2023-09-01T22:26:27Z: Remove unneeded replace gopkg.in/fsnotify.v1
2023-09-01T22:26:44Z: Remove unneeded replace gopkg.in/fsnotify.v1
2023-09-10T13:56:38Z: GPG key expired / regression on Linux repository (EXPKEYSIG)
2023-09-15T23:53:23Z: Bump to ginkgo v2
2023-09-15T23:58:04Z: add github action test
2023-09-19T21:26:45Z: Pauseoutputinterception
2023-09-22T21:43:10Z: Make go 1.21 the new minimum
2023-09-22T21:49:28Z: Make go 1.21 the new minimum
2023-09-22T21:54:45Z: Make go 1.21 the new minimum
2023-09-22T22:13:43Z: Remove circular dependency on hydra integration
2023-10-18T17:49:26Z: test v8 branch with dummy change to readme
2023-10-18T19:00:18Z: Remove Eventually statement for enable ssh tip
2023-10-19T18:01:47Z: Update generate release notes to include arm mac packages
2023-10-19T18:14:37Z: Update generate release notes to include arm mac packages
2023-10-19T18:20:02Z: Update generate release notes to include arm mac packages
2023-10-23T11:53:58Z: Add state to buildpacks output
2023-10-25T21:31:11Z: Bump google.golang.org/grpc from 1.58.2 to 1.58.3
2023-10-31T17:54:24Z: Update path for add-persistent-isolation-segment-diego-cell.yml
2023-10-31T17:55:52Z: Update path for add-persistent-isolation-segment-diego-cell.yml
2023-10-31T17:56:38Z: Update path for add-persistent-isolation-segment-diego-cell.yml
2023-10-31T19:20:13Z: Put back old test/add-persistent-isolation-segment-diego-cell.yml path
2023-10-31T19:20:56Z: Put back old test/add-persistent-isolation-segment-diego-cell.yml path
2023-11-01T18:43:46Z: Bump go log cache and go loggregator main
2023-11-01T18:44:37Z: Bump go log cache and go loggregator v8
2023-11-01T18:45:20Z: Bump go log cache and go loggregator v7

Code contributions:

2021-08-26T16:38:40Z: Update repo-index.yml
2021-08-26T16:39:23Z: update metric registrar
2022-06-16T22:22:23Z: Update Contributing to use go 1.18
2022-09-20T21:13:42Z: Use jq instead of grep -P for finding users to delete during integrat… (#2319)
2022-09-20T21:25:07Z: Allow user to rename app if buildpack is deleted (#2321)
2022-09-22T18:35:11Z: Use Eventually/Should for routes_command list routes with http1 and (#2324)
2022-10-13T20:29:23Z: Replace ioutil.ReadFile with embed for fixtures
2022-10-13T22:36:46Z: Use default of 1GB memory instead of 32M
2022-10-20T22:28:54Z: Deploys OIDC provider for github integration tests
2022-10-21T21:39:47Z: Add Isolation Segment to GitHub Actions Integration Tests (#2335)
2022-10-21T21:59:22Z: Explicity enable route_sharing feature on tests that need it (#2331)
2023-01-26T22:52:32Z: Add cflinuxfs4 - wip
2023-01-27T00:51:36Z: Add an app that errors on cflinuxfs4
2023-01-31T00:54:12Z: shell out to cf restart - wip
2023-02-01T23:46:49Z: Fix zero downtime when app fails to run
2023-02-02T00:48:33Z: Convert integration tests to ginkgo from spec
2023-02-02T21:13:52Z: Use cf restage instead of restart
2023-02-02T23:51:07Z: Remove unused features
2023-02-03T00:10:55Z: Remove unused testdata and update run the tests section of the readme
2023-02-03T00:53:48Z: Replace spec with ginkgo
2023-02-14T19:49:56Z: Fix integration and unit test scripts
2023-02-14T19:52:53Z: Remove deprecated pkg/errors in favor of go's standard errors library
2023-02-14T22:07:30Z: bump libbuildpack to latest
2023-02-14T22:31:53Z: bump cli to 7.1.0
2023-03-17T22:19:47Z: Add github actions to test prs (#25)
2023-03-17T22:21:32Z: Add dependabot to keep up to date (#26)
2023-05-05T23:27:45Z: Use specific ruby buildpack for does_not_stage_on_fs4 app
2023-05-20T01:07:33Z: remove unzip instructions in readme
2023-08-18T23:07:26Z: turn on dependabot for branches v7 and v8 in support
2023-08-25T17:04:23Z: keep github actions up to date
2023-08-25T17:55:13Z: Add use latest ruby-buildpack for when we test with older cf-deployments
2023-08-25T18:05:43Z: Use latest ruby buildpack for min capi tests
2023-08-29T23:52:16Z: release 8.7.2
2023-08-30T23:22:56Z: add 7.7.2 release (#58)
2023-10-12T15:24:33Z: Make go 1.21 the new minimum (#2586)
2023-10-27T22:09:52Z: Use harbor proxy to fetch cfcli/cli-base image
2023-10-31T18:33:26Z: Update path for add-persistent-isolation-segment-diego-cell.yml (#2643)
2023-10-31T20:14:30Z: Put back old test/add-persistent-isolation-segment-diego-cell.yml path (#2646)
2023-11-01T22:57:09Z: Bump go log cache and go loggregator main (#2648)
2023-11-16T16:26:19Z: Update generate release notes to include arm mac packages (#2629)

beyhan mentioned this pull request

[RFC] Add criteria and define a removal process for inactive users #707

Merged

Member

beyhan commented Nov 28, 2023

@a-b is this promotion still relevant because there is no activity on the PR?

Contributor

ccjaimes commented Nov 28, 2023

I support Michael's promotion to a CLI Approver!

ccjaimes approved these changes

View reviewed changes

Member Author

a-b commented Nov 28, 2023

@beyhan I confirm that this promotion is still relevant. Thank you for taking the time to double-check.

Gerg approved these changes

View reviewed changes

Member

Gerg left a comment

Congratulations on your promotion!

Member

Gerg commented Nov 29, 2023

Merging this PR is currently blocked on resolving merge conflicts.

Member

beyhan commented Dec 1, 2023

@a-b could you please resolve the conflicts so that we can merge it.

ameowlia merged commit 3b3f6f0 into cloudfoundry:main

2 checks passed

Member

ameowlia commented Dec 4, 2023

✅ resolved merge conflicts and merged. Congrats @moleske!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wg