Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote klaus-sap to UAA approver #718

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

klaus-sap
Copy link
Contributor

No description provided.

@klaus-sap klaus-sap changed the title promote klaus-sap to approver Promote klaus-sap to UAA approver Dec 4, 2023
Copy link
Member

@strehle strehle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beyhan beyhan added the wg label Dec 5, 2023
@beyhan
Copy link
Member

beyhan commented Dec 13, 2023

According to the the Promotion to Reviewer or Approver we need two approvals. It will be good if we could get an approval from different involved parties.

@beyhan
Copy link
Member

beyhan commented Jan 22, 2024

Copy link
Contributor

@Tallicia Tallicia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@beyhan
Copy link
Member

beyhan commented Jan 23, 2024

Thanks and welcome as reviewer @klaus-sap.

@beyhan beyhan merged commit 5ac4d66 into cloudfoundry:main Jan 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants