Add blgm as approver to app-runtime-interfaces #721
Conversation
I received an email saying that due to some cleanup I was going to have my access to [jsonry](https://github.com/cloudfoundry/jsonry) removed. As the person who maintains this repo, I thought that could be unhelpful as it could become unmaintained. JSONry was a spin-off from some code that once lived in the CF CLI, and it seems that it's [actually used as a library](https://github.com/cloudfoundry/jsonry/network/dependents) by other projects. In addition to maintaining JSONry, I have made significant contributions to the [CF CLI](https://github.com/cloudfoundry/cli/commits?author=blgm), so being an Approver in this group could make sense. I'm completely behind the idea to clean up authorization and ownership of repos. If it's felt that I don't quite meet the criteria, or that they would be better solutions, then I don't have a problem with that. My aim is to be helpful by continuing to help out with JSONry and the services sub-commands in the CF CLI, but there are many ways to achieve that.
|
CC @cloudfoundry/wg-app-runtime-interfaces-cli-approvers for review |
|
Per https://github.com/cloudfoundry/community/blob/main/toc/ROLES.md#promotion-to-reviewer-or-approver, you need 2 existing CLI approvers to review your application. Once the review is complete, I can merge this PR. |
|
ping @ccjaimes, @moleske, @reedr3, @jdgonzaleza, @a-b |
There was a problem hiding this comment.
I did not realize the cli approver group owned jsonry. Since George has clearly been maintaining (thanks George!) it I'm in favor of making him and approver.
That said, I'm also open to moving jsonry to a more appropriate approver group, or sharing it with another approver group if that makes sense. I'm not sure where'd it be shared or moved to
|
@a-b, @jdgonzaleza, @reedr3, @ccjaimes, @gururajsh: one more +1 is needed to get this PR merged |
|
Welcome! |
I received an email saying that due to some cleanup I was going to have my access to jsonry removed. As the person who maintains this repo, I thought that could be unhelpful as it could become unmaintained.
JSONry was a spin-off from some code that once lived in the CF CLI, and it seems that it's actually used as a library by other projects.
In addition to maintaining JSONry, I have made significant contributions to the CF CLI, so being an Approver in this group could make sense.
I'm completely behind the idea to clean up authorization and ownership of repos. If it's felt that I don't quite meet the criteria, or that they would be better solutions, then I don't have a problem with that. My aim is to be helpful by continuing to help out with JSONry and the services sub-commands in the CF CLI, but there are many ways to achieve that.