Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move homebrew-tap to Admin WG from Foundational Infrastructure WG #967

Merged
merged 4 commits into from
Sep 17, 2024

Conversation

gururajsh
Copy link
Member

Since CF CLI uses homebrew-tap repository is used by teams across multiple WGs, moving it to Admin WG. Related PR #944.

Have included some of the current CLI approvers as approvers for this.

@beyhan
Copy link
Member

beyhan commented Sep 6, 2024

FYI (current approvers of cloudfoundry/homebrew-tap) @aramprice ,@ystros ,@selzoc ,@dlresende ,@totherme ,@blgm ,@ifindlay-cci ,@klakin-pivotal, @nouseforaname ,@jhvhs ,@lnguyen ,@ragaskar the cloudfoundry/homebrew-tap repository will be moved with this pr from the FI WG to the shared area in the Admin WG as discussed in #944. Pls comment on this pr if you still want to be an approver.

Copy link
Member

@beyhan beyhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gururajsh could you please also remove the repository from FI WG with this pr. Maybe we can change the title of the pr to move instead of add.

@beyhan beyhan requested review from a team, rkoster, beyhan, stephanme, ameowlia, ChrisMcGowan and jpalermo and removed request for a team September 6, 2024 06:45
@beyhan beyhan added the toc label Sep 6, 2024
@gururajsh gururajsh changed the title Add homebrew-tap to Admin WG Move homebrew-tap to Admin WG from Foundational Infrastructure WG Sep 6, 2024
@gururajsh
Copy link
Member Author

@gururajsh could you please also remove the repository from FI WG with this pr. Maybe we can change the title of the pr to move instead of add.

Done.

@aramprice
Copy link
Member

@beyhan - does this mean that the Admin WG will be responsible for publishing / approving new versions of bosh-cli, bbr and bbl formulae?

@beyhan
Copy link
Member

beyhan commented Sep 9, 2024

@beyhan - does this mean that the Admin WG will be responsible for publishing / approving new versions of bosh-cli, bbr and bbl formulae?

@aramprice The approves of the area will be responsible. Admin WG is just a location we thought which is good for repositories which need to be shared across WGs.

@jpalermo
Copy link
Member

jpalermo commented Sep 9, 2024

Yeah, the bosh-cli pipelines won't break with this move since we use a deploy key in the pipeline to update the tap. So we don't really need anybody involved with this area to continue as we are now. Is that fine?

Copy link
Member

@ameowlia ameowlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes all approvers from the Foundational Infrastructure working group. Now there are only approvers from the App Runtime Interfaces working group.

❓ Is this intended?

If this is the desired outcome and it doesn't need to be shared between groups then it doesn't need to live in the Admin WG.

toc/ADMIN.md Outdated Show resolved Hide resolved
toc/ADMIN.md Outdated
@@ -60,6 +60,22 @@ areas:
- cloudfoundry/summit-hands-on-labs
- cloudfoundry/summit-training-classes
- cloudfoundry/training-cert-admin

- name: Shared
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be changed to: CF Homebrew TAP

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

toc/ADMIN.md Show resolved Hide resolved
@beyhan beyhan merged commit c8de4c6 into cloudfoundry:main Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

9 participants