-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move homebrew-tap to Admin WG from Foundational Infrastructure WG #967
Conversation
FYI (current approvers of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gururajsh could you please also remove the repository from FI WG with this pr. Maybe we can change the title of the pr to move instead of add.
Done. |
@beyhan - does this mean that the Admin WG will be responsible for publishing / approving new versions of |
@aramprice The approves of the area will be responsible. Admin WG is just a location we thought which is good for repositories which need to be shared across WGs. |
Yeah, the bosh-cli pipelines won't break with this move since we use a deploy key in the pipeline to update the tap. So we don't really need anybody involved with this area to continue as we are now. Is that fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This removes all approvers from the Foundational Infrastructure working group. Now there are only approvers from the App Runtime Interfaces working group.
❓ Is this intended?
If this is the desired outcome and it doesn't need to be shared between groups then it doesn't need to live in the Admin WG.
toc/ADMIN.md
Outdated
@@ -60,6 +60,22 @@ areas: | |||
- cloudfoundry/summit-hands-on-labs | |||
- cloudfoundry/summit-training-classes | |||
- cloudfoundry/training-cert-admin | |||
|
|||
- name: Shared |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be changed to: CF Homebrew TAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Co-authored-by: Amelia Downs <[email protected]>
Since CF CLI uses homebrew-tap repository is used by teams across multiple WGs, moving it to Admin WG. Related PR #944.
Have included some of the current CLI approvers as approvers for this.