Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Golang 1.23 in the DRATS and credhub-test-app go modules #363

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

davewalter
Copy link
Member

This PR bumps the Golang modules files to 1.23 and attempts to make them less restrictive so they aren't sensitive to patch version changes in the Golang buildpack. It also introduces a couple of CI changes:

  • a new GitHub workflow to run the unit tests on PRs and changes to main
  • an updated Concourse pipeline to run the disaster recovery tests themselves using the CATs environment

- Use 1.23 without a patch version to allow any patch version to be used.
- Add a Golang toolchain directive to the go.mod files.
@davewalter davewalter requested a review from a team December 31, 2024 00:10
@davewalter davewalter force-pushed the make-go-mod-less-restrictive branch 2 times, most recently from a6ab51d to ca2c0f2 Compare December 31, 2024 19:49
@davewalter davewalter force-pushed the make-go-mod-less-restrictive branch from ca2c0f2 to 1404d84 Compare December 31, 2024 20:35
ctlong
ctlong previously approved these changes Jan 7, 2025
.github/workflows/unit-tests.yml Outdated Show resolved Hide resolved
@davewalter davewalter force-pushed the make-go-mod-less-restrictive branch from a949350 to d63bf3a Compare January 7, 2025 02:55
@davewalter davewalter merged commit d0ee154 into main Jan 7, 2025
2 checks passed
@davewalter davewalter deleted the make-go-mod-less-restrictive branch January 7, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants