Include filemode when zipping source in e2es #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieron-dev
force-pushed
the
debug-blob-unknown
branch
2 times, most recently
from
01b97b5
to
39f1f20
Compare
e2e tests need to store the file mode when zipping the source This stops the latest iteration of the BLOB_UNKNOWN flake on GKE / GAR Co-authored-by: Giuseppe Capizzi <[email protected]>
kieron-dev
force-pushed
the
debug-blob-unknown
branch
from
39f1f20
to
dac7eaa
Compare
kieron-dev
changed the title
gcapizzi
approved these changes
Jul 6, 2023
tcdowney
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Our mitigation against the GKE/GAR UNKNOWN_BLOB error is to pre-push the apps we push in the e2e tests. However, we ended up with different droplets when using
cf pushto those created in the e2e code.The difference turned out to be omitting file permissions when we zipped the source in e2es. So this PR sets the file mode while zipping.
Does this PR introduce a breaking change?
No
Acceptance Steps
See UNKNOWN_BLOB flakes reduce / stop
Tag your pair, your PM, and/or team
@gcapizzi