handle non-resizable storage classes for build cache #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We now set build cache size on kpack Images, but if we already have an Image, and we try to change the size setting and repush the app, the operation will fail if the storage class doesn't support resize. This change checks the storage class and deletes the image if resizing isn't supported. #2634 Co-authored-by: Julian Hjortshoj <[email protected]>
davewalter
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2634What is this change about?
We set build cache size on kpack
Images, but if we already have anImage, and we try to change the buildCacheMB setting, redeploy Korifi, and then repush an app, the operation will fail if the storage class doesn't support resize, because kpack will try to modify the persistent disk. This change checks the storage class and deletes theImageif resizing isn't supported.Does this PR introduce a breaking change?
NoAcceptance Steps
#2634
Tag your pair, your PM, and/or team
@davewalter