Make the job handler generic #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the job handler more generic
The handler now receives a map from job type to a `DeletionRepository`, which is all it needs to implement the deletion job logic. Supporting deletion jobs for new resources is now only a matter of implementing the `DeletionRepository` interface for the resource repository, and then add an entry to the map.
This makes it easy to create a nested logger starting from the one in the context *and* re-inject it into the context so that it can be easily passed on. Co-authored-by: Giuseppe Capizzi <[email protected]>
Co-authored-by: Giuseppe Capizzi <[email protected]>
gcapizzi
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2606
What is this change about?
In order to support other resource types in the job handler we introduce a map from resource type to a
DeletionRegistryimplementation. Repositories are expected to implement that interface.Does this PR introduce a breaking change?
No
Acceptance Steps
N/A
Tag your pair, your PM, and/or team
@gcapizzi