Operator can configure limit of staging MemoryMB #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#2654] Reorganized the staging resource configuration under its own struct to better capture the intent of the fields. Co-authored-by: Dave Walter <[email protected]>
davewalter
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2654
What is this change about?
Allow operator to configure the staging resources limits. Passes through the MemoryMB configuration to the underlying kpack build pod in the kpack-image-builder controller.
Does this PR introduce a breaking change?
No. Only breaking changes are internal to the controller configmap, which we do not expect operators to manually edit or provide themselves.
Acceptance Steps
See issue.
Tag your pair, your PM, and/or team
paired w/ @davewalter