Make all status.conditions fields optional and annotated with omitempty #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we no longer have to initialize them to empty slices before making non-related status changes (mainly in tests). All instances of this have been removed. Issue: #2580 Co-authored-by: Kieron Browne <[email protected]>
gcapizzi
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2580
What is this change about?
Ensure all status.conditions fields are optional and decorated with
omitempty.This means we no longer have to initialize them to empty slices before making non-related status changes (mainly in tests). All instances of this have been removed.
Does this PR introduce a breaking change?
No
Acceptance Steps
Tag your pair, your PM, and/or team
@gcapizzi