Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cg-1342): support opsworks services #131

Open
wants to merge 5 commits into
base: alpha
Choose a base branch
from

Conversation

zhouse51
Copy link
Contributor

@zhouse51 zhouse51 commented May 4, 2023

Issue tracker links

Add links to any relevant tasks/stories/bugs/pagerduty/etc

Example - dummy TODO project

TODO-123

Changes/solution

How does this change address the problem?

Testing

Describe how the testing was done, plus evidence, if not covered by automated tests

Notes and considerations

Add any additional notes and/or considerations

Dependencies

_Add dependencies on any other PRs, if applicable

@zhouse51 zhouse51 requested review from tyler-dunkel and m-pizarro May 4, 2023 23:59
@zhouse51
Copy link
Contributor Author

zhouse51 commented May 5, 2023

@tyler-dunkel @m-pizarro I have a comment in the [opsworksApp/format.ts]

Also, the code is not fully tested. I just ran it without data. I didn't create any opsworks resources in AWS. Don't know what set of services need to create and afraid this would cost a lot. Could someone create a set of test services?

@tyler-dunkel
Copy link
Contributor

@tyler-dunkel @m-pizarro I have a comment in the [opsworksApp/format.ts]

Also, the code is not fully tested. I just ran it without data. I didn't create any opsworks resources in AWS. Don't know what set of services need to create and afraid this would cost a lot. Could someone create a set of test services?

@ckoning whats the cost for setting up opswork?

@zhouse51
Copy link
Contributor Author

@tyler-dunkel test the data and updated the arn builder to use the appId

@m-pizarro
Copy link
Contributor

@tyler-dunkel it's ready to go. We only have a opsWorksStack to test but I think we can go ahead. Unless you want to test the other services also...
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants