-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(services): rename tables and properties to fix postgres long nam… #99
base: alpha
Are you sure you want to change the base?
Conversation
@@ -54,7 +54,7 @@ type awsElastiCachePendingModifiedValues | |||
engineVersion: String @search(by: [hash, regexp]) | |||
cacheNodeType: String @search(by: [hash, regexp]) | |||
authTokenStatus: String @search(by: [hash, regexp]) | |||
logDeliveryConfigurations: [awsElastiCachePendingLogDeliveryConfiguration] | |||
logDeliveryConfigurations: [awsElastiCachePendLogDeliveryConfig] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm do we need to change pending
=> pend
, I wonder if there might be a better way here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what will the query look like on the SQL side with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I leave the awsElastiCachePendingLogDeliveryConfiguration
and rename the logDeliveryConfigurations
property to logDeliveryConfigs
, let me know if this works for you.
@tyler-dunkel This is deprecated, these changes were made to use Hasura. I think we can close it. |
…es errors
Issue tracker links
Add links to any relevant tasks/stories/bugs/pagerduty/etc
Example - dummy TODO project
TODO-123
Changes/solution
How does this change address the problem?
Testing
Describe how the testing was done, plus evidence, if not covered by automated tests
Notes and considerations
Add any additional notes and/or considerations
Dependencies
_Add dependencies on any other PRs, if applicable