feat: rewrite of ngx-sub-form without inheritance #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2020
MikeMatusz
reviewed
Sep 30, 2020
This was
linked to
issues
Oct 11, 2020
Closed
This was
linked to
issues
Oct 11, 2020
Closed
This is a major architecture change which is brought without any breaking change 😄! We've split up the code base in 2: Old one and new one. The old one hasn't moved at all but is now deprecated (not removed yet!). You can keep using the old one for a bit and have a smooth/incremental update to use the new API. Few changes that you have to note with the new API: - Only works with Angular 9 or more - The app needs to have Ivy activated (this is because we use `ɵmarkDirty` internally. If it ever gets removed we'll probably have to ask to provide the `ChangeDetectorRef` but we were able to around this for now!) - We got rid of inheritance 🙌 - Form errors on a FormArray are now an object instead of an array. Previously the array contained null values on all the fields without any error. It's now an object containing only the ones with errors and you can access them using the index Please start upgrading to the new API as soon as possible as we stop supporting the old API as of today and will remove it in a near release. This closes #171 for the major architectural changes and also the following issues as a result: - closes #82 - closes #86 - closes #93 - closes #133 - closes #143 - closes #144 - closes #149 - closes #160 - closes #168
…orm and ngx-sub-form/new to avoid making a breaking change
…we can import only from that one when migrating
…so that we can override some defaults
This feature was available before and got forgotten in the new one
…mponent which are not bind to their input will never be able to emit updates
…een useful yet and causes issues
BREAKING CHANGE: By upgrading to Angular 13, ngx-sub-form will now stop publishing view engine compatible bundle. If you're still running a pre Angular 13 version and want to use ngx-sub-form from here it should still be safe to do so thanks to ngcc. If you're on Angular 13 already then when you install the dependencies by running `npm install` or `yarn` you shouldn't see `ngx-sub-form` in the list of libraries being compiled by ngcc anymore.
We should restore those later but I don't want to have to deal with this during the upgrade
zakhenry
previously approved these changes
Nov 21, 2021
maxime1992
changed the title
maxime1992
force-pushed
the
feat-rewrite
branch
from
b17d07b to
bea385d
Compare
zakhenry
approved these changes
Nov 21, 2021
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.