Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose and test creation of test.img #28

Merged
merged 2 commits into from
Dec 30, 2014
Merged

Expose and test creation of test.img #28

merged 2 commits into from
Dec 30, 2014

Conversation

lucafavatella
Copy link
Contributor

No description provided.

maximk added a commit that referenced this pull request Dec 30, 2014
Expose and test creation of test.img
@maximk maximk merged commit cb5f7bd into cloudozer:master Dec 30, 2014
@maximk
Copy link
Contributor

maximk commented Dec 30, 2014

We will also need to "run" the tests. This requires integration with erlangonxen.org to upload the image and boot it up. If the tests are ok the travis should report success.

@lucafavatella lucafavatella deleted the test-img branch December 30, 2014 15:18
@lucafavatella
Copy link
Contributor Author

We will also need to "run" the tests. This requires integration with erlangonxen.org to upload the image and boot it up. If the tests are ok the travis should report success.

@maximk Do you mean starting an EC2 instance as described at http://erlangonxen.org/try/ec2? (it makes no sense for me)

@maximk
Copy link
Contributor

maximk commented Dec 30, 2014

@lucafavatella The easier option is to run it on erlangonxen.org. It works already for lincx. @krant will fix this.

@lucafavatella
Copy link
Contributor Author

[...] The easier option is to run it on erlangonxen.org. It works already for lincx. [...]

I see you mean like this. It looks to me that that approach has the issue that PRs from contributors cannot run the tests e.g. FlowForwarding/lincx#18.

In order to ease contributions it would be needed to have a documented/easy way for contributors to set up a local dev environment where to run the tests. Are you interested in reusing https://github.com/lucafavatella/provisioning-osx/tree/master/vm? (affected by network issue described at #21 (comment))

@maximk
Copy link
Contributor

maximk commented Dec 30, 2014

I have no objection. It would be great if deployment for tests (or other things) is easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants