Don't add a header to empty files #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python requries package folders to have an '__init__.py' file, but usually this file is empty. Since there is no code in the file adding a copyright header seemed to me to be a bit non-sensicle. I suppose this could be a flag, but I really can't think of why anyone should need a copyright header for an empty file?
aknysh
reviewed
Mar 11, 2019
There was a problem hiding this comment.
thanks @jisaacstone LGTM
could you please check why the CI/CD is failing https://travis-ci.org/cloudposse/copyright-header/builds/503926596?utm_source=github_status&utm_medium=notification ?
|
Looks like couldn't find the |
|
nah yeah that did not work. Sorry I don't actually know ruby at all so I'm not sure exactly what is going on, looks like there is a ~> 6.0 version for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python requires package folders to have an 'init.py' file, but usually this file is empty.
Since there is no code in the file adding a copyright header seemed to me to be a bit nonsensical.
I suppose this could be a flag, but I really can't think of why anyone should need a copyright header for an empty file?