Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instance_name to outputs to return a list of cluster instance identifiers #47

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

larsfuehrer
Copy link

what

  • Add a instance_name output for the cluster instance identifier.

why

  • e.g. if you want to add a aws_cloudwatch_metric_alarm resource to your Documentdb cluster ( dimensions = { DBInstanceIdentifier = ....} )
  • get the value from the output (e.g. module.documentdb_cluster.instance_name)

@larsfuehrer larsfuehrer requested review from a team as code owners May 3, 2022 12:37
@larsfuehrer larsfuehrer requested review from Gowiem and milldr May 3, 2022 12:37
@larsfuehrer
Copy link
Author

larsfuehrer commented Aug 2, 2022

@Gowiem @milldr could you pls review the PR.

@larsfuehrer
Copy link
Author

unbelievable, nothing happens here!!! its just an output .....

@kevcube
Copy link
Contributor

kevcube commented Nov 28, 2023

/terratest

@kevcube
Copy link
Contributor

kevcube commented Nov 28, 2023

@hans-d
Copy link

hans-d commented Mar 8, 2024

/terratest

@hans-d hans-d added the stale This PR has gone stale label Mar 8, 2024
Copy link

mergify bot commented Mar 9, 2024

Thanks @larsfuehrer for creating this pull request!

A maintainer will review your changes shortly. Please don't be discouraged if it takes a while.

While you wait, make sure to review our contributor guidelines.

Tip

Need help or want to ask for a PR review to be expedited?

Join us on Slack in the #pr-reviews channel.

@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants