fix: remove join calls on bucket arn + id usage

[carterdanko-dw]

what

• Initially put the wrong values for coditions, just needs to be a list
• Bucket should be single resource vs joining on a list.

references

issue #122

[Gowiem]

I'm not sure this PR does anything. join just converts the module.aws_s3_bucket.bucket_arn to a string and if multiple were given, you'd end up with them joined with no separator. With that being the case, these changes were probably never needed to add the join, but now that they're there... I'm unsure if this is providing anything.

Can you please clarify if you were hitting an issue with this code and include the error that you received if so?

Also, mentioning #122 here so it's correctly linked.

[carterdanko-dw]

@Gowiem Yep!

When trying to apply the stack, I get this error

│ Error: Invalid function argument
│
│   on .terraform/core/modules/cloudtrail_s3_bucket.s3_bucket/sqs_notifications.tf line 36, in data "aws_iam_policy_document" "sqs_policy":
│   36:       values   = [join("", module.aws_s3_bucket.bucket_arn)]
│     ├────────────────
│     │ while calling join(separator, lists...)
│     │ module.aws_s3_bucket.bucket_arn is "arn:aws:s3:::BUCKET_NAME_REDACTED"
│
│ Invalid value for "lists" parameter: list of string required.

after modifying the local .terraform files to test, and re-running my plan I get this error

╷
│ Error: Invalid function argument
│
│   on .terraform/core/modules/cloudtrail_s3_bucket.s3_bucket/sqs_notifications.tf line 49, in resource "aws_s3_bucket_notification" "bucket_notification":
│   49:   bucket = join("", module.aws_s3_bucket.bucket_id)
│     ├────────────────
│     │ while calling join(separator, lists...)
│     │ module.aws_s3_bucket.bucket_id is "BUCKET_NAME_REDACTED"
│
│ Invalid value for "lists" parameter: list of string required.

but then modifying the .terraform file locally and planning was able to create the notification as expected.

FWIW running this with OpenTofu v1.8.3

[Gowiem]

/terratest

[Gowiem]

LGTM

[github-actions]

These changes were released in v1.4.5.