chore: Update tsconfig target to ES2019 #3986
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3986 +/- ##
==========================================
- Coverage 97.18% 97.14% -0.04%
==========================================
Files 857 857
Lines 25303 25045 -258
Branches 8967 8967
==========================================
- Hits 24590 24331 -259
+ Misses 707 665 -42
- Partials 6 49 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
All targeted browsers support ES2021 syntax. This change provides an immediate bundle size reduction, with the potential for further gains if code is rewritten to take advantage of optional chaining and nullish coalescing. * Optional chaining: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#browser_compatibility * Nullish coalescing: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing#browser_compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the TypeScript target from the current setting to "ES2019" instead of "ES2021" (as proposed in PR #3801). This is to address build failures in the dry run while still improving TypeScript compatibility.
The change is similar to what was done in the component-toolkit repository (PR #169), where changing to ES2019 was successful without causing downstream failures with Webpack 4 compatibility.
Related links, issue #, if available:
Original PR with ES2021 target (to be closed): #3801
Similar successful change in component-toolkit: cloudscape-design/component-toolkit#169
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.