Skip to content

Conversation

@just-boris
Copy link
Member

@just-boris just-boris commented Nov 4, 2025

Description

Unblocking this change: cloudscape-design/component-toolkit#172

The code needs to be updated for compatibility with the changes from another package

Related links, issue #, if available: n/a

How has this been tested?

PR build passes

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@just-boris just-boris force-pushed the fix-modal-root branch 2 times, most recently from e2f8653 to abecf7f Compare November 4, 2025 18:16
* The function will be called when a user clicks on the trigger button.
*/
getModalRoot?: () => Promise<HTMLElement>;
getModalRoot?: PortalProps['getContainer'];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature of this function will change. Replacing the manual signature with a type reference to mirror the signature from the upstream without copying

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.25%. Comparing base (58547d1) to head (03bbac9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4007   +/-   ##
=======================================
  Coverage   97.25%   97.25%           
=======================================
  Files         859      859           
  Lines       25394    25394           
  Branches     9047     9048    +1     
=======================================
  Hits        24697    24697           
+ Misses        691      650   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@just-boris just-boris marked this pull request as ready for review November 4, 2025 21:40
@just-boris just-boris requested a review from a team as a code owner November 4, 2025 21:40
@just-boris just-boris requested review from jperals and removed request for a team November 4, 2025 21:40
@just-boris just-boris added this pull request to the merge queue Nov 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 5, 2025
@just-boris just-boris added this pull request to the merge queue Nov 5, 2025
Merged via the queue into main with commit 927f6bc Nov 5, 2025
84 of 85 checks passed
@just-boris just-boris deleted the fix-modal-root branch November 5, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants