enhancement#93 : Implemented TF code for firestore creation. #114
Conversation
…d [gke with the correct Firestore create command parameter
it up by using Terraform or manually.
terraform/modules/firestore/main.tf
Outdated
| } | ||
|
|
||
| resource "google_firestore_database" "database" { | ||
| count = var.terraform_firestore_create ? 1 : 0 |
There was a problem hiding this comment.
Since this is in the Terraform module for Firestore, wouldn't using the module indicate we want to create the Firestore database. Also choosing to not create the database while using the module would break the setup, correct?
There was a problem hiding this comment.
Hello,
thanks for the review,
I sort of agree with you but if we do not provide an option then we will end up forcing the user to use Firestore. What in case if the user wants to use Spanner to store the Autoscaler state?
Should we still create the Firestore db as a default setup and let the user use Spanner without utilizing the provisioned Firestore db?
Let me know if my understanding is not accurate.
Thanks!
There was a problem hiding this comment.
Previously, if the user wanted to store state in Spanner the documentation instructed them to skip the gcloud command to create the Firestore database. Now with the module users in that situation should just not include the Firestore module in their Terraform.
4 participants
Implemented code for enhancement#93 .
Please let me know if I am missing anything.