Merge ODBC restoration from 5.1 to 5.2 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ActiveRecord SQLServer Adapter defaults to TinyTDS. And the support for ODBC has been removed. This is the effort to support Adapter with ODBC Driver again. - ruby-odbc is now pointed to https://github.com/cloudvolumes/ruby-odbc - restricted sqlite3 version to < 1.4
…he Ruby::ODBC module - The UTF8 version does not appear to support multiple statements in a single query. So things like "query; SELECT @@rowcount" do not work
- Error found: SerializedAttributeTest#test_json_read_legacy_null: ActiveRecord::RecordNotFound: Couldn't find Topic without an ID - updated sql_for_insert method to use OUTPUT clause to get the ID of the last inserted record and with a single sql statement
- Error found: MigrationTestSQLServer::For changing column#test_0002_not drop the default contraint if just renaming: TypeError: no implicit conversion of String into Integer - array needs to be flattened before calling select method
…1900-01-01 - SQLserver uses 1900-01-01 as default date instead of current date - Reference: https://docs.microsoft.com/en-us/sql/relational-databases/native-client-odbc-date-time/datetime-data-type-conversions-from-sql-to-c?view=sql-server-2017
- Error found: ActiveRecord::ValueTooLong: ODBC::Error: 22001 (8152)[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]String or binary data would be truncated. - Require odbc_utf8 so that UTF-8 variant of the module is in use, and string data is automatically converted to/from Unicode
…ed as binary / ASCII-8Bit - Added a check to make sure the object is String. ActiveRecord tests passes objects which are other than String. - Added a check to make sure we are not modifying the frozen object. There are tests which passes frozen objects.
- TinyTDS gem for windows is compiled with OpenSSL with a version that has vulnerabilities - Updating to use ruby-odbc as dependency, as this forked repository is for connecting to SQLServer in ODBC mode
Merge commits made to 5-0-stable-with-odbc branch with 5-1-stable-odbc
- use SET NOCOUNT ON so that the number of rows affected by INSERT statement is returned instead of the number of rows affected by the trigger - Refer https://techcommunity.microsoft.com/t5/SQL-Server/UPDATE-with-OUTPUT-clause-8211-Triggers-8211-and-SQLMoreResults/ba-p/383457
Fix trigger_test_sqlserver test case failure
Version bump to 5.1.6.odbc to support ODBC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create the 5.2 branch in this repository from the base repository.
First I cloned the base repository, then checked out 5-2-stable branch:
Then I added this forked repository as an additional upstream:
Then I pushed the HEAD of the that branch (5-2-stable) to that the avfork repository:
We probably want to rebase these changes on top of the branch instead of merge them because we really just want to repeat the changes on top of whatever changes went into 5.2 as some of the files that we changed may have changed underneath us.