Skip to content

fix(deps): fix 8 Dependabot alerts (high) - #2755

Merged
carneiro-cw merged 1 commit into
mainfrom
factory/deps-stratus
Oct 26, 2026
Merged

carneiro-cw merged 1 commit into
mainfrom
factory/deps-stratus

Conversation

@c3ru

@c3ru c3ru commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Moves undici to 6.29.1, fast-uri to 3.1.9, serialize-javascript to 7.1.3 to fix 8 open Dependabot alerts (highest: high). Alerts

package from → to severity advisory
undici >= 6.23.0, < 6.29.1 → 6.29.1 high GHSA-xjj6-f33q-929c
undici >= 6.23.0, < 6.29.1 → 6.29.1 high GHSA-xjj6-f33q-929c
fast-uri >= 3.0.0, < 3.1.9 → 3.1.9 medium GHSA-w74x-v6f9-j3xg
fast-uri >= 3.1.3, < 3.1.9 → 3.1.9 medium GHSA-wjr9-j795-jxcr
fast-uri >= 3.0.0, < 3.1.9 → 3.1.9 low GHSA-xhq7-xmqj-769h
fast-uri >= 3.0.0, < 3.1.9 → 3.1.9 low GHSA-333x-w4r6-6crp
serialize-javascript < 7.1.3 → 7.1.3 low GHSA-m5mm-p8h7-m29v
serialize-javascript < 7.1.3 → 7.1.3 low GHSA-m5mm-p8h7-m29v

Why this change

undici is a direct dependency, listed in e2e/cloudwalk-contracts/integration/package.json, so e2e/cloudwalk-contracts/integration/package.json and e2e/cloudwalk-contracts/integration/package-lock.json change.
serialize-javascript is a transitive dependency (via hardhat and 1 other package), so e2e/cloudwalk-contracts/integration/package.json pins it and e2e/cloudwalk-contracts/integration/package-lock.json changes.
fast-uri is a transitive dependency (via @nomicfoundation/hardhat-toolbox and 1 other package), so e2e/package.json pins it and e2e/package-lock.json changes.

How it was checked

  • Installed from the lockfile, then ran the test suite and the build; all pass on a clean Mac.
  • Every alert's package is at or above its patched version in the lockfile.
  • CI on this PR: see the checks below. The PR merges only when they are green.

What you need to do

Review and approve. Once approved and green, the PR is merged for you.

Verification log
$ cd e2e && mise exec -- npm ci → exit 0
$ cd e2e/cloudwalk-contracts/integration && mise exec -- npm ci → exit 0
$ cd e2e && mise exec -- node_modules/.bin/hardhat compile → exit 0
$ cd e2e/cloudwalk-contracts/integration && mise exec -- node_modules/.bin/hardhat compile → exit 0
$ cd e2e && mise exec -- node_modules/.bin/prettier . --check --ignore-unknown → exit 0
$ cd e2e
set -euo pipefail
mise exec -- node_modules/.bin/hardhat node --hostname 127.0.0.1 > /tmp/stratus-e2e-hardhat-smoke-node-t78934.log 2>&1 &
node_pid=$!
cleanup() { kill "$node_pid" 2>/dev/null || true; wait "$node_pid" 2>/dev/null || true; }
trap cleanup EXIT
for i in $(seq 1 60); do
  if curl -sS -X POST -H 'content-type: application/json' --data '{"jsonrpc":"2.0","method":"eth_chainId","params":[],"id":1}' http://127.0.0.1:8545 >/dev/null 2>&1; then break; fi
  sleep 1
done
BLOCK_MODE=automine mise exec -- node_modules/.bin/hardhat test test/automine/e2e-json-rpc.test.ts --grep 'Metadata' --network hardhat → exit 0
$ python3 - <<'PY'
import json
checks={
 'e2e/package-lock.json': {'undici':'6.29.1','serialize-javascript':'7.1.3','fast-uri':'3.1.9'},
 'e2e/cloudwalk-contracts/integration/package-lock.json': {'undici':'6.29.1','serialize-javascript':'7.1.3'},
}
for f, expected in checks.items():
 data=json.load(open(f))
 for name, version in expected.items():
  matches=[entry['version'] for path,entry in data['packages'].items() if path == 'node_modules/'+name or path.endswith('/node_modules/'+name)]
  assert matches and all(found == version for found in matches), (f, name, matches)
print('All requested lockfile versions are patched.')
PY → exit 0
$ git diff --check → exit 0
undici GHSA-xjj6-f33q-929c: found [6.29.1] need >= 6.29.1
serialize-javascript GHSA-m5mm-p8h7-m29v: found [7.1.3] need >= 7.1.3
fast-uri GHSA-w74x-v6f9-j3xg: found [3.1.9] need >= 3.1.9
fast-uri GHSA-xhq7-xmqj-769h: found [3.1.9] need >= 3.1.9
fast-uri GHSA-wjr9-j795-jxcr: found [3.1.9] need >= 3.1.9
fast-uri GHSA-333x-w4r6-6crp: found [3.1.9] need >= 3.1.9
undici GHSA-xjj6-f33q-929c: found [6.29.1] need >= 6.29.1
serialize-javascript GHSA-m5mm-p8h7-m29v: found [7.1.3] need >= 7.1.3

Tracked in cloudwalk/dependabot-factory#480.

undici >= 6.29.1 (GHSA-xjj6-f33q-929c, high)
undici >= 6.29.1 (GHSA-xjj6-f33q-929c, high)
fast-uri >= 3.1.9 (GHSA-w74x-v6f9-j3xg, medium)
fast-uri >= 3.1.9 (GHSA-wjr9-j795-jxcr, medium)
fast-uri >= 3.1.9 (GHSA-xhq7-xmqj-769h, low)
fast-uri >= 3.1.9 (GHSA-333x-w4r6-6crp, low)
serialize-javascript >= 7.1.3 (GHSA-m5mm-p8h7-m29v, low)
serialize-javascript >= 7.1.3 (GHSA-m5mm-p8h7-m29v, low)
@c3ru
c3ru requested a review from a team as a code owner October 26, 2026 16:05

@cloudwalk-review-agent cloudwalk-review-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Dependency remediation looks consistent and complete across both e2e workspaces:

  • undici updated to 6.29.1 in direct deps, overrides, and lockfiles.
  • serialize-javascript updated to 7.1.3 via overrides and reflected in lockfiles.
  • fast-uri updated to 3.1.9 and reflected in lockfile.
  • Older nested undici@6.24.0 lockfile entries were removed, indicating deduping to patched versions.

I did not find concrete correctness or security regressions in the provided diff; this is a focused dependency/security update with matching manifest+lockfile changes.

@github-actions

Copy link
Copy Markdown
Contributor

Failed to generate code suggestions for PR

@carneiro-cw
carneiro-cw merged commit 4c187f1 into main Oct 26, 2026
11 checks passed
@carneiro-cw
carneiro-cw deleted the factory/deps-stratus branch October 26, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants