Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ut for assert.NotNil #1181

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

ElvisWai
Copy link
Contributor

@ElvisWai ElvisWai commented Aug 28, 2024

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复 assert的 NotNil 不生效。(参数判断有误)

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):
#1179

(Optional) Which issue(s) this PR fixes:

close #1178

(Optional) The PR that updates user documentation:

@ElvisWai ElvisWai requested review from a team as code owners August 28, 2024 10:33
@ElvisWai
Copy link
Contributor Author

@welkeyever 改好了,approval 一下试试 workflows 结果

@welkeyever
Copy link
Member

@welkeyever 改好了,approval 一下试试 workflows 结果

pr 按照模板来哈,这个模板是关联自动发版的,格式需要 follow 下

@welkeyever
Copy link
Member

ci 里可以直接看到结果,应该还有点问题:
image

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2024

CLA assistant check
All committers have signed the CLA.

@ElvisWai ElvisWai force-pushed the fix/asert_notnil branch 2 times, most recently from 64f2b03 to 5610a91 Compare August 30, 2024 04:29
@ElvisWai
Copy link
Contributor Author

ci 里可以直接看到结果,应该还有点问题: image

那个问题我本地用 go 1.20.14 的容器跑 ut 是成功。挺疑惑在 workflows 里面为啥会不通过 😭

Copy link
Member

@welkeyever welkeyever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx~

@welkeyever welkeyever merged commit 63f9ab5 into cloudwego:develop Sep 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix assert.NotNil not working
4 participants