Do not allow changes to feed/thread, metric/imperial, forward/reverse…

…, or settings when the machine is running.
clough42 · Oct 6, 2020 · 94ebec9 · 94ebec9
1 parent 9debd0b
commit 94ebec9
Showing 1 changed file with 28 additions and 19 deletions.
diff --git a/els-f280049c/UserInterface.cpp b/els-f280049c/UserInterface.cpp
@@ -116,6 +116,9 @@ void UserInterface :: loop( void )
 {
     const FEED_THREAD *newFeed = NULL;
 
+    // read the RPM up front so we can use it to make decisions
+    Uint16 currentRpm = core->getRPM();
+
     // display an override message, if there is one
     overrideMessage();
 
@@ -128,22 +131,32 @@ void UserInterface :: loop( void )
     keys = controlPanel->getKeys();
 
     // respond to keypresses
-    if( keys.bit.IN_MM )
-    {
-        this->metric = ! this->metric;
-        newFeed = loadFeedTable();
-    }
-    if( keys.bit.FEED_THREAD )
+    if( currentRpm == 0 )
     {
-        this->thread = ! this->thread;
-        newFeed = loadFeedTable();
-    }
-    if( keys.bit.FWD_REV )
-    {
-        this->reverse = ! this->reverse;
-        // feed table hasn't changed, but we need to trigger an update
-        newFeed = loadFeedTable();
+        // these keys should only be sensitive when the machine is stopped
+        if( keys.bit.IN_MM )
+        {
+            this->metric = ! this->metric;
+            newFeed = loadFeedTable();
+        }
+        if( keys.bit.FEED_THREAD )
+        {
+            this->thread = ! this->thread;
+            newFeed = loadFeedTable();
+        }
+        if( keys.bit.FWD_REV )
+        {
+            this->reverse = ! this->reverse;
+            // feed table hasn't changed, but we need to trigger an update
+            newFeed = loadFeedTable();
+        }
+        if( keys.bit.SET )
+        {
+            setMessage(&SETTINGS_MESSAGE_1);
+        }
     }
+
+    // these keys can be operated when the machine is running
     if( keys.bit.UP )
     {
         newFeed = feedTable->next();
@@ -152,10 +165,6 @@ void UserInterface :: loop( void )
     {
         newFeed = feedTable->previous();
     }
-    if( keys.bit.SET )
-    {
-        setMessage(&SETTINGS_MESSAGE_1);
-    }
 
     // if we have changed the feed
     if( newFeed != NULL ) {
@@ -170,7 +179,7 @@ void UserInterface :: loop( void )
     }
 
     // update the RPM display
-    controlPanel->setRPM(core->getRPM());
+    controlPanel->setRPM(currentRpm);
 
     // write data out to the display
     controlPanel->refresh();