fix editor losing focus on save #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix bug where editor would lose focus on save - adjust debounce to original timing
cloverich
commented
Dec 31, 2024
| initialValue={value as any} | ||
| onChange={setValue} | ||
| plugins={plugins} | ||
| readOnly={saving} |
There was a problem hiding this comment.
I'm not sure why this line was here, and also unsure why this didn't trigger noticeable focus loss before; would have been less noticeable with the prior settings, but should have still been noticeable...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should really make the saving more intelligent (long pause, and allow user to leave note and save in background)...