improve document error handling #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add better error display and ability to navigate when a document errors unexpectedly - refactor Alert to simplify interface - add better behavior when document not found (navigates back to homepage with toast); clean-up invalid error handling Closes #260
cloverich
force-pushed
the
improve_doc_errors
branch
from
dac706f to
2e612c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now displays the stack inside navigation, and outputs the document it tried to load. Alert is not pretty, but its better than it was (and also not evergreen, #215 )
When document not found, instead of empty screen with a line of text, navigates back to documents search page with toast; this was the original intent but miscue on handling the not found error resulted in this being mixed up.
There's also some corrections to other kinds of errors being caught, but did not test these.
Closes #260