Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arbitrum Goerli #561

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Add Arbitrum Goerli #561

merged 1 commit into from
Sep 23, 2022

Conversation

yuetloo
Copy link
Collaborator

@yuetloo yuetloo commented Sep 20, 2022

Add Arbitrum Goerli as a supported chain.

@yuetloo yuetloo self-assigned this Sep 20, 2022
auryn-macmillan
auryn-macmillan approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@auryn-macmillan auryn-macmillan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

One thing I'd like to do at some point in future (not urgent) is to define network specific RPC endpoints in the .env file.
I find myself having to frequently edit the RPC endpoint variable because I'm switching between different networks.

@yuetloo yuetloo mentioned this pull request Sep 23, 2022
Open
@yuetloo
Copy link
Collaborator Author

yuetloo commented Sep 23, 2022

Lgtm!

One thing I'd like to do at some point in future (not urgent) is to define network specific RPC endpoints in the .env file. I find myself having to frequently edit the RPC endpoint variable because I'm switching between different networks.

I created issue #564 to track this request.

@yuetloo yuetloo merged commit 772e879 into develop Sep 23, 2022
@yuetloo yuetloo deleted the feat/arbitrum-goerli branch September 23, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auryn-macmillan auryn-macmillan auryn-macmillan approved these changes

Assignees

@yuetloo yuetloo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuetloo @auryn-macmillan