Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTSP streams support #169

Merged
merged 8 commits into from
May 9, 2023
Merged

Add RTSP streams support #169

merged 8 commits into from
May 9, 2023

Conversation

GLDuval
Copy link
Collaborator

@GLDuval GLDuval commented May 6, 2023

This PR allows the UI to view RTSP streams by specifying RTSP stream links and using the new rtsp camera type. For now a delay of about 1 second is being observed when using RTSP streams, but the streams require a lot less bandwidth on the network. During testing, 3 720p camera feeds were using about 2.5Mbit/s on the network which is about 6x less than our current implementation with an even better quality.

script/rtspServer.js Outdated Show resolved Hide resolved
src/main/rtspServer.ts Outdated Show resolved Hide resolved
@GLDuval
Copy link
Collaborator Author

GLDuval commented May 7, 2023

I did some small cleanups, but I still have a small issue when switching between rtsp streams. I'm not too sure what causes the issue, but when switching between 2 rtsp streams directly the rtsp stream will not be played. A quick work around for this issue is simply to switch to a non rtsp stream in between. For example: rtsp -> empty -> rtsp works. I tried some stuff to fix the issue, but I wasn't successful we can maybe keep this like this for now since the competition is getting closer.

Leuchak
Leuchak previously approved these changes May 8, 2023
Copy link
Member

@Leuchak Leuchak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work :P

I did some small cleanups, but I still have a small issue when switching between rtsp streams. I'm not too sure what causes the issue, but when switching between 2 rtsp streams directly the rtsp stream will not be played. A quick work around for this issue is simply to switch to a non rtsp stream in between. For example: rtsp -> empty -> rtsp works. I tried some stuff to fix the issue, but I wasn't successful we can maybe keep this like this for now since the competition is getting closer.

It's ok, open an issue that explains the problem.
We will manage later according to priorities.

saxtot
saxtot previously approved these changes May 9, 2023
@GLDuval GLDuval dismissed stale reviews from saxtot and Leuchak via 29eb398 May 9, 2023 14:57
@GLDuval GLDuval merged commit 6b7e24a into master May 9, 2023
1 check passed
@GLDuval GLDuval deleted the rtsp-viewer branch May 9, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants