Player: Modified reputation gain calculations

[JJBcku]

I have modified the calculation of level difference penalties for reputation gain to be more in line with the original World of Warcraft.

🍰 Pullrequest

Proof

• Reddit
• Reddit 2
• Blizzard forum

Issues

• fixes non vanilla wow-like reputation gains

[JJBcku]

Could someone tell me why there is no discussion or even acknowledgment of my pull request?
Have I did something wrong?

[insunaa]

Currently nobody on the dev team has the time to review pull requests

[killerwife]

@ratkosrb

[killerwife]

I understand this is based on the forum post, but have you actually tested this on classic PTR or what specifically is this based on (I have read the links pointing it out)

[killerwife]

After careful investigation, the function GetGrayLevel is deprecated and IsTrivialLevelDifference is the correct one. (trivial means grey in official naming)

I went ahead and a 48 npc (green) on lvl 60 gives full rep, and the GetGrayLevel function would not do that properly

[killerwife]

So here you are saying the reputation penalty isnt related for quest case with "grayness" in any way, but only related to the + 5 constant (cos gray level is dynamic based on level of source)

[killerwife]

My proposed code based on client lua:

    if (source == REPUTATION_SOURCE_KILL)
    {
        if (MaNGOS::XP::IsTrivialLevelDifference(currentLevel, creatureOrQuestLevel))
        {
            const uint32 greenRange = MaNGOS::XP::GetQuestGreenRange(currentLevel);
            percent *= std::max(minRate, (1.0f - (0.2f * (currentLevel - greenRange - creatureOrQuestLevel))));
        }
    }
    else if (source == REPUTATION_SOURCE_QUEST)
    {
        // Pre-3.0.8: Declines with 20% for each level if 6 levels or more below the player down to a minimum (default: 20%)
        const uint32 treshold = (creatureOrQuestLevel + 5);

        if (currentLevel > treshold)
            percent *= std::max(minRate, (1.0f - (0.2f * (currentLevel - treshold))));
    }

Test case, grey mob in vanilla at 47 (grey diff in vanilla is 12 levels per client and lua) will get 80% rep. Quest case unchanged.

[JJBcku]

Hi,
I have added checking for the trivial level difference in the modified function.
I have not found a function named GetQuestGreenRange in Mangos::XP so instead I have modified the GetGrayLevel function to return values in line with the ones IsTrivialLevelDifference is using.

[killerwife]

The function exists in lua client code. I extracted it over here: 9e95f5d take a look

[JJBcku]

Thank you for your help.
Could you tell me the email I should use to credit you as a co-author.

[killerwife]

Just look at git history in commandline, its there. I prefer not to write it here cos it kinda leads to more spam email for me :D

[JJBcku]

I have added the changes you suggested.
I have kept in the fix for the GetGrayLevel function, is that okay?

[killerwife]

I will review how all 3 cores use them and then I will merge it. We prefer to use official functions from client whenever named and available. The gray level one doesnt exist in client.