Skip to content

Conversation

@eliasfloreteng
Copy link

@eliasfloreteng eliasfloreteng commented Oct 21, 2025

See the PR for the main repo at louislam#872

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds an editor for compose override files (see https://docs.docker.com/compose/how-tos/multiple-compose-files/merge/) if there is one in the directory of the stack. It will appear above the editor for the normal compose file. It does not appear in the create menu, only when editing and if the file exists.

This is the second most requested feature in the discussions: louislam#278 and louislam#415

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Screenshot 2025-10-21 at 19 07 35

Copy link
Owner

@cmcooper1980 cmcooper1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR submitted.
Unless I missed something and I could be wrong, however, please review and correct the necessary code for approval to be merged. edited: seeing your screenshot, could be due to prism editor vs codemirror

There are no reported obvious conflicts so I have cloned, merged, and locally tested with the 4 acceptable override file names: compose.override.yml, compose.override.yaml, docker-compose.override.yml, and docker-compose.override.yaml.

issue:
While the absence of these files behaves as described with no compose.override.yaml section displayed and with their existence the section is shown in the WebUI, the resulting field is a single empty line (not expanded nor editable).

image image image

expected behavior:
When the file exists, content of that file should be displayed/field expanded to extent of file contents and editable (when Edit is selected).

@eliasfloreteng
Copy link
Author

Okay thanks for investigating this, I haven't tested it extensively with your fork, but I will do that and see if it can be fixed, but it may involve some changes that should not be merged to the original repo, so I may create a new PR

@cmcooper1980
Copy link
Owner

Okay thanks for investigating this, I haven't tested it extensively with your fork, but I will do that and see if it can be fixed, but it may involve some changes that should not be merged to the original repo, so I may create a new PR

Sure, understandable..

@cmcooper1980 cmcooper1980 merged commit d303cd3 into cmcooper1980:master Nov 5, 2025
@cmcooper1980
Copy link
Owner

merged then fixed to use codemirror instead of prism-editor as not to commit to upstream branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants