chore(dspy): remove unused to_openai_text_request mapper and helpers - #120
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Greptile SummaryRemoves an unused OpenAI text-completion request mapper and its private helper functions.
Confidence Score: 5/5The PR appears safe to merge because the removed symbols are unused and the active text-completion paths remain intact. No actionable failure remains; repository-wide reference checks found no consumers, and both synchronous and asynchronous text-completion functions independently construct their prompts. Important Files Changed
Reviews (1): Last reviewed commit: "chore(dspy): remove unused to_openai_tex..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
to_openai_text_requestfunction and its cascading dead code(
messages_to_text_prompt,text_config_kwargs, the section header, and thecorresponding docstring/
__all__entries). These symbols had no callersanywhere in the codebase, tests, or docs. The actual text-completion path in
dspy/clients/lm.py(litellm_text_completion/alitellm_text_completion)builds its prompt inline and does not use this mapper, so it never wired up
since the module was introduced.
📝 Changes Description
This MR/PR contains the following changes:
to_openai_text_request(the only__all__symbol with zero callers anywhere)messages_to_text_promptandtext_config_kwargs(their sole consumer wasto_openai_text_request)__all__to drop the references✅ Contributor Checklist
Detail: Dead Code
History
Dead Code PRs can be configured here.