chore: remove dead helpers in dspy/propose/utils - #130
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Greptile SummaryThis PR removes three isolated, unused instruction-history helpers from
Confidence Score: 5/5The PR appears safe to merge because it only removes isolated dead code with no tracked callers or public exports. No actionable failures remain; repository references and package exports confirm that the deleted helpers and import were unused. Important Files Changed
Reviews (1): Last reviewed commit: "chore: remove dead helpers in dspy/propo..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove three unused top-level functions from dspy/propose/utils.py: create_instruction_set_history_string, parse_list_of_instructions, and get_program_instruction_set_string. Also drop the now-unneeded "import json" that only parse_list_of_instructions used.
These functions had no production callers, no test references, and were not re-exported in dspy/propose/init.py. They were added in the initial MIPRO release commit and never wired up; get_program_instruction_set_string was only called by the dead create_instruction_set_history_string. A repo-wide search confirms no imports or call sites.
History
Last materially changed June 2024 (stanfordnlp#1169 @XenonMolecule).
Dead Code PRs can be configured here.