Skip to content

chore(retrievers): remove single_query_passage dead helper - #131

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-retrievers-remove-single-query-passage-dead-649471
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-retrievers-remove-single-query-passage-dead-649471

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 16, 2026

Copy link
Copy Markdown

📝 Changes Description

Removes the unused top-level single_query_passage helper from dspy/retrievers/retrieve.py (10 lines).

The function had zero callers anywhere in the codebase (production, tests, docs, or notebooks), was not exported in any __init__.py, and was never documented. Its only two call sites — in Retrieve.forward's with_metadata branch and the now-deleted RetrieveThenRerank class — were removed in the V2.6 deprecations (stanfordnlp#1936), leaving the helper orphaned. It has been unreferenced since.

History

✅ Contributor Checklist

  • Pre-Commit checks are passing (locally and remotely)
  • Title of your PR / MR corresponds to the required format
  • Commit message follows required format {label}(dspy): {message}

⚠️ Warnings

None.


Dead Code PRs can be configured here.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the unused, unexported single_query_passage helper from the retriever module.

  • Deletes dead aggregation logic with no known consumers.
  • Leaves the supported Retrieve API unchanged.

Confidence Score: 5/5

This PR appears safe to merge because it only removes an unused, unexported helper with no repository consumers.

No actionable failures remain; the deleted symbol was absent from package exports and had no references in production code, tests, documentation, examples, or notebooks.

Important Files Changed

Filename Overview
dspy/retrievers/retrieve.py Safely removes an unreferenced module-level helper without changing the exported retriever API.

Reviews (1): Last reviewed commit: "chore(retrievers): remove single_query_p..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants