chore: remove legacy OldField and new_to_old_field bridge - #132
Open
detail-app[bot] wants to merge 1 commit into
Open
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
Greptile SummaryThis PR removes the unused legacy field compatibility layer from
Confidence Score: 5/5The PR appears safe to merge because it cleanly removes an unreferenced legacy compatibility layer without affecting current field APIs. No repository callers or documented compatibility requirements remain for the removed symbols, and no functional or security defects were identified. Important Files Changed
Reviews (1): Last reviewed commit: "chore: remove legacy OldField and new_to..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unused legacy field classes (OldField, OldInputField, OldOutputField) and the new_to_old_field bridge function from dspy.signatures, along with their re-exports in the package init.
These symbols were the bridge from the new pydantic-based Signature/field system to the legacy dsp.Template format, used by signature_to_template, langchain.py, and llamaindex.py. All callers were deliberately removed in the "V2.6 RC-01: Deprecations" PR (stanfordnlp#1936, Dec 2024); the symbols no longer have any production, test, or doc references. The 'Old' naming signaled deprecation intent. new_to_old_field was not even exported and had zero call-sites.
History
Dead Code PRs can be configured here.