Skip to content

chore(utils): remove unused dummy_rm helper - #138

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-utils-remove-unused-dummy-rm-helper-96b8a4
Open

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-utils-remove-unused-dummy-rm-helper-96b8a4

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 16, 2026

Copy link
Copy Markdown

Removes the ''dummy_rm'' retrieval-manager helper and its re-export from ''dspy.utils''. The function had zero callers anywhere (no production, test, or doc usage); its only consumers (legacy ''tests/dsp_LM/'' and ''tests/functional/'' suites) were deliberately removed in the V2.6 RC-01 deprecations (stanfordnlp#1936), leaving it a left-over utility with no live feature.

History


Dead Code PRs can be configured here.

@greptile-apps

greptile-apps Bot commented Sep 16, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the unused dummy_rm retrieval helper and its re-export from dspy.utils.

  • Deletes the helper implementation from dspy.utils.dummies.
  • Removes the symbol from the package import surface and __all__.
  • The implementation is unused internally, but removing the released public export introduces an immediate downstream compatibility break.

Confidence Score: 4/5

The PR is not yet safe to merge because existing consumers of the exported helper will encounter an immediate import failure.

The implementation itself is internally unused and cleanly removable, but deleting an explicitly exported 3.x API symbol without a deprecation shim creates a concrete downstream compatibility failure.

Files Needing Attention: dspy/utils/init.py

Important Files Changed

Filename Overview
dspy/utils/init.py Removes dummy_rm from the explicit public package API without a compatibility or deprecation period.
dspy/utils/dummies.py Deletes the unused helper implementation without leaving unused dependencies or internal references.

Reviews (1): Last reviewed commit: "chore(utils): remove unused dummy_rm hel..." | Re-trigger Greptile

Comment thread dspy/utils/__init__.py
from dspy.utils.annotation import experimental
from dspy.utils.callback import BaseCallback, with_callbacks
from dspy.utils.dummies import DummyLM, DummyVectorizer, dummy_rm
from dspy.utils.dummies import DummyLM, DummyVectorizer

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Public API removed abruptly

Removing dummy_rm from this explicit public export without a deprecation period breaks downstream code that imports it from dspy.utils. Those applications will fail during import after upgrading, even though the package remains on version 3.3.1. Preserve a compatibility shim with a deprecation warning until the intended removal version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants