chore(utils): remove unused dummy_rm helper - #138
detail-app[bot] wants to merge 1 commit into
Conversation
Greptile SummaryRemoves the unused
Confidence Score: 4/5The PR is not yet safe to merge because existing consumers of the exported helper will encounter an immediate import failure. The implementation itself is internally unused and cleanly removable, but deleting an explicitly exported 3.x API symbol without a deprecation shim creates a concrete downstream compatibility failure. Files Needing Attention: dspy/utils/init.py Important Files Changed
Reviews (1): Last reviewed commit: "chore(utils): remove unused dummy_rm hel..." | Re-trigger Greptile |
| from dspy.utils.annotation import experimental | ||
| from dspy.utils.callback import BaseCallback, with_callbacks | ||
| from dspy.utils.dummies import DummyLM, DummyVectorizer, dummy_rm | ||
| from dspy.utils.dummies import DummyLM, DummyVectorizer |
There was a problem hiding this comment.
Removing dummy_rm from this explicit public export without a deprecation period breaks downstream code that imports it from dspy.utils. Those applications will fail during import after upgrading, even though the package remains on version 3.3.1. Preserve a compatibility shim with a deprecation warning until the intended removal version.
Removes the ''dummy_rm'' retrieval-manager helper and its re-export from ''dspy.utils''. The function had zero callers anywhere (no production, test, or doc usage); its only consumers (legacy ''tests/dsp_LM/'' and ''tests/functional/'' suites) were deliberately removed in the V2.6 RC-01 deprecations (stanfordnlp#1936), leaving it a left-over utility with no live feature.
History
Dead Code PRs can be configured here.