forked from stanfordnlp/dspy
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(adapter): render typed history frames #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isaacbmiller
wants to merge
1
commit into
isaac/react-v2-pr1-history-raw-dicts
Choose a base branch
from
isaac/react-v2-pr2-history-formatting
base: isaac/react-v2-pr1-history-raw-dicts
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import json | ||
|
|
||
| import dspy | ||
| from dspy.adapters.types.history import History, Observation | ||
|
|
||
|
|
||
| def add(a: int, b: int) -> int: | ||
| """Add two numbers.""" | ||
| return a + b | ||
|
|
||
|
|
||
| class AgentTurn(dspy.Signature): | ||
| question: str = dspy.InputField() | ||
| history: dspy.History = dspy.InputField() | ||
| tools: list[dspy.Tool] = dspy.InputField() | ||
| next_thought: str = dspy.OutputField() | ||
| tool_calls: dspy.ToolCalls = dspy.OutputField() | ||
|
|
||
|
|
||
| def _history_with_open_tool_turn() -> History: | ||
| history = History(frames=[]) | ||
| history.append_inputs({"question": "What is 1+2?"}) | ||
| history.append_outputs( | ||
| { | ||
| "next_thought": "I should add.", | ||
| "tool_calls": dspy.ToolCalls.from_dict_list([{"name": "add", "args": {"a": 1, "b": 2}}]), | ||
| }, | ||
| observations=[Observation(value=3, source="tool", name="add")], | ||
| ) | ||
| return history | ||
|
|
||
|
|
||
| def test_chat_adapter_formats_open_history_without_duplicate_input(): | ||
| messages = dspy.ChatAdapter().format( | ||
| AgentTurn, | ||
| [], | ||
| {"question": "What is 1+2?", "history": _history_with_open_tool_turn(), "tools": [dspy.Tool(add)]}, | ||
| ) | ||
|
|
||
| texts = [message.text or "" for message in messages] | ||
|
|
||
| assert [message.role for message in messages] == ["system", "user", "assistant", "user", "user"] | ||
| assert sum("What is 1+2?" in text for text in texts[1:]) == 1 | ||
| assert "[[ ## next_thought ## ]]\nI should add." in texts[2] | ||
| assert "[[ ## tool_calls ## ]]" in texts[2] | ||
| assert "Tool call 1 (`add`):\nObservation: 3" in texts[3] | ||
| assert "Respond with the corresponding output fields" in texts[4] | ||
|
|
||
|
|
||
| def test_json_adapter_formats_open_history_without_duplicate_input(): | ||
| messages = dspy.JSONAdapter().format( | ||
| AgentTurn, | ||
| [], | ||
| {"question": "What is 1+2?", "history": _history_with_open_tool_turn(), "tools": [dspy.Tool(add)]}, | ||
| ) | ||
|
|
||
| texts = [message.text or "" for message in messages] | ||
| assistant = json.loads(texts[2]) | ||
|
|
||
| assert [message.role for message in messages] == ["system", "user", "assistant", "user", "user"] | ||
| assert sum("What is 1+2?" in text for text in texts[1:]) == 1 | ||
| assert assistant["next_thought"] == "I should add." | ||
| assert assistant["tool_calls"]["tool_calls"][0]["function"]["name"] == "add" | ||
| assert "Tool call 1 (`add`):\nObservation: 3" in texts[3] | ||
| assert "Respond with a JSON object" in texts[4] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[[ ## completed ## ]]marker in mixed-output fallbackWhen
outputscontains both signature-recognized fields (signature_outputs) and unrecognized fields (unknown_outputs), the fallback branch callsformat_assistant_message_content— which itself appends[[ ## completed ## ]]— strips it, then appends the unknown-field sections and another[[ ## completed ## ]]. The resulting assistant history turn carries two end-of-turn sentinels, which can mislead the LM about the expected format or cause the DSPy response parser to stop early on any future response that contains a first completed marker before all fields.The fast path (
if signature_outputs and not unknown_outputs) is clean; the fix is to also strip the trailing[[ ## completed ## ]]from theformat_assistant_message_contentoutput before joining, so the final explicitsections.append("[[ ## completed ## ]]")is the only one.