Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first pass at htmlwidget improvements #21

Merged
merged 8 commits into from
Sep 24, 2015
Merged

Conversation

timelyportfolio
Copy link
Contributor

This pull includes a first pass at improvements to the htmlwidget interface for datacomb. Some noticeable changes:

  • move R package stuff to ./pkg which will require the additional subdir="pkg" argument to devtools::install_github("cmpolis/datacomb,subdir="pkg") but allows us to separate the R stuff
  • do some opinionated guessing to hopefully simplify usage on the part of the R user
  • add some examples and documentation

see #1 for the full discussion and history

@cmpolis
Copy link
Owner

cmpolis commented Sep 24, 2015

👍 👍 👍 Really appreciate this; thank you!

cmpolis added a commit that referenced this pull request Sep 24, 2015
first pass at htmlwidget improvements
@cmpolis cmpolis merged commit 0cba34e into cmpolis:master Sep 24, 2015
@timelyportfolio
Copy link
Contributor Author

You've done all the hard work. Still a long way to go on the R side, but I love that with one-line an R user can make a datacomb, so we have a platform for iteration. Happy to make this the htmlwidget of the week when you think ready for the very little publicity that I can muster.

@cmpolis
Copy link
Owner

cmpolis commented Sep 24, 2015

Haha, yeah, it's pretty remarkable you can get such a rich interface w/ just a single line of R; thanks again! I put in a few small updates, fixes, updated the dir structure, readme and did some cleanup tonight. I think things are in a pretty good state to share- feel free to publicize whenever you'd like!

@timelyportfolio
Copy link
Contributor Author

Everything works great/better after your merge and changes. Will write a post this afternoon or tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants