Skip to content

Conversation

@veluca93
Copy link
Contributor

No description provided.

@veluca93 veluca93 requested a review from wil93 November 17, 2024 01:44
@codecov
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@6d8c919). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1280   +/-   ##
=========================================
  Coverage          ?   46.95%           
=========================================
  Files             ?      234           
  Lines             ?    17160           
  Branches          ?        0           
=========================================
  Hits              ?     8057           
  Misses            ?     9103           
  Partials          ?        0           
Flag Coverage Δ
functionaltests 46.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wil93 wil93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to re-order the lists of languages so they're sorted alphabetically. Also for "COMPILED_LANGUAGES" maybe there's a better name, since right now Python is in it too?

Lastly, maybe we can avoid having to add new languages in multiple lists by specifying languages to remove instead of to add, something like:

LIST_OF_LANGUAGES = removeFromList(ALL_LANGUAGES, [LANG_PYTHON3])

@veluca93
Copy link
Contributor Author

It would be nice to re-order the lists of languages so they're sorted alphabetically. Also for "COMPILED_LANGUAGES" maybe there's a better name, since right now Python is in it too?

Lastly, maybe we can avoid having to add new languages in multiple lists by specifying languages to remove instead of to add, something like:

LIST_OF_LANGUAGES = removeFromList(ALL_LANGUAGES, [LANG_PYTHON3])

In CMS, Python is a compiled language ;) (it has a separate compilation step)

wil93
wil93 previously approved these changes Nov 17, 2024
@veluca93 veluca93 merged commit 59bb400 into cms-dev:master Nov 17, 2024
3 checks passed
@wil93 wil93 deleted the cleanup-tests branch November 18, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants