-
Notifications
You must be signed in to change notification settings - Fork 399
Test more language variants in communication #1280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1280 +/- ##
=========================================
Coverage ? 46.95%
=========================================
Files ? 234
Lines ? 17160
Branches ? 0
=========================================
Hits ? 8057
Misses ? 9103
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wil93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to re-order the lists of languages so they're sorted alphabetically. Also for "COMPILED_LANGUAGES" maybe there's a better name, since right now Python is in it too?
Lastly, maybe we can avoid having to add new languages in multiple lists by specifying languages to remove instead of to add, something like:
LIST_OF_LANGUAGES = removeFromList(ALL_LANGUAGES, [LANG_PYTHON3])
In CMS, Python is a compiled language ;) (it has a separate compilation step) |
9c0b4fa to
d580d8d
Compare
d580d8d to
a353952
Compare
a353952 to
3cb8f47
Compare
3cb8f47 to
d396f30
Compare
No description provided.