-
Notifications
You must be signed in to change notification settings - Fork 400
AWS: don't refresh the page when contest phase changes #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prandla
added a commit
to e-i-o/cms
that referenced
this pull request
Aug 17, 2025
prandla
added a commit
to e-i-o/cms
that referenced
this pull request
Aug 21, 2025
240ca5b to
be007f0
Compare
veluca93
approved these changes
Aug 23, 2025
ronryv
added a commit
to ioi-isr/cms
that referenced
this pull request
Nov 1, 2025
* CWS: Mark ajax request endpoints as @api_login_required (cms-dev#1522) This prevents cases where they would redirect to the login screen unexpectedly. Also improved handling of errors in the submission details popup. * AWS: don't refresh the page when contest phase changes (cms-dev#1510) * make AWS more resilient towards missing ScoreTypes and Languages (cms-dev#1460) * Translated using Weblate (Estonian) Currently translated at 100.0% (311 of 311 strings) Translation: CMS/main Translate-URL: https://hosted.weblate.org/projects/cms/main/et/ * Translated using Weblate (French) Currently translated at 100.0% (311 of 311 strings) Translation: CMS/main Translate-URL: https://hosted.weblate.org/projects/cms/main/fr/ * Translated using Weblate (Arabic) Currently translated at 54.9% (171 of 311 strings) Translation: CMS/main Translate-URL: https://hosted.weblate.org/projects/cms/main/ar/ * Translated using Weblate (Chinese (Traditional Han script)) Currently translated at 67.5% (210 of 311 strings) Translation: CMS/main Translate-URL: https://hosted.weblate.org/projects/cms/main/zh_Hant/ * Translated using Weblate (Italian) Currently translated at 100.0% (311 of 311 strings) Translation: CMS/main Translate-URL: https://hosted.weblate.org/projects/cms/main/it/ * Initialize Hebrew translation * mention weblate more explicitly in README (cms-dev#1531) this was requested by the Weblate support team. * Remove some unused files (cms-dev#1533) We don't use codacy any more (at least it doesn't seem so?) and we use weblate instead of onesky now. * Fix possible timing leak in validate_password (cms-dev#1535) * Make the helper scripts in docker/ a bit more robust When the git repo is in a detached HEAD state, GIT_BRANCH_NAME became "HEAD", which docker does not like as a project name. So I lowercased it and added a cms- in front for good measure. * Make functional test suite not depend on git * Bump gevent from 25.5.1 to 25.8.1 (cms-dev#1538) Bumps [gevent](https://github.com/gevent/gevent) from 25.5.1 to 25.8.1. - [Release notes](https://github.com/gevent/gevent/releases) - [Changelog](https://github.com/gevent/gevent/blob/master/docs/changelog_pre.rst) - [Commits](gevent/gevent@25.5.1...25.8.1) --- updated-dependencies: - dependency-name: gevent dependency-version: 25.8.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix schema_diff_test on new debian (cms-dev#1551) * Bump zope-event from 5.1 to 6.0 (cms-dev#1555) Bumps [zope-event](https://github.com/zopefoundation/zope.event) from 5.1 to 6.0. - [Changelog](https://github.com/zopefoundation/zope.event/blob/master/CHANGES.rst) - [Commits](zopefoundation/zope.event@5.1...6.0) --- updated-dependencies: - dependency-name: zope-event dependency-version: '6.0' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump zope-interface from 7.2 to 8.0 (cms-dev#1554) Bumps [zope-interface](https://github.com/zopefoundation/zope.interface) from 7.2 to 8.0. - [Changelog](https://github.com/zopefoundation/zope.interface/blob/master/CHANGES.rst) - [Commits](zopefoundation/zope.interface@7.2...8.0) --- updated-dependencies: - dependency-name: zope-interface dependency-version: '8.0' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump version to 1.6.dev0 (cms-dev#1532) * Add rws public config and configurable id column * Avoid reading GEN if score parameters are already found in task.yaml * Fixes --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: p. randla <[email protected]> Co-authored-by: Pasit Sangprachathanarak <[email protected]> Co-authored-by: Muaath Alqarni <[email protected]> Co-authored-by: LittleCube <[email protected]> Co-authored-by: William Di Luigi <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Elia Soldati <[email protected]> Co-authored-by: Francesco Vercellesi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We frequently have a problem where the AWS service gets overloaded right at the end of a contest. I suspect this is because the client-side logic tries to refresh the page the instant the contest ends, when most jury members will have multiple tabs of AWS open (I usually end up with over 10...).
The phase of the contest is used solely to show the remaining time countdown. So instead I computed the phase in the countdown logic itself. This required duplicating the "current phase" logic from python to javascript, but I don't think it's a big deal, because half of this logic was duplicated in that javascript function already.