Dt extended data format

[NTrevisani]

PR description:

The main target of this pull request is to include additional information in the DT DataFormat for phase2, both for phi and theta. The user can decide whether to save the additional information or not. In the latter case, no changes are expected.
The extended DataFormat inherits from the original one and includes:

• local position and slope;
• global coordinates obtained using CMSSW (instead of FW-like LUTs)
• hit wire information (ID, TDC, and laterality).

The PR also updates some aspects of the pseudo-bayes grouping algorithm for trigger primitives generation.

PR validation:

Run the DT phase2 emulator with new DataFormat using the cfg file at: L1Trigger/DTTriggerPhase2/test/test_primitivesPhase2Prod_DEBUG_Grouping_cfg.py, obtaining the same results as before.

Also produce DT ntuples and checked that efficiencies and resolutions are left unchanged.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34025/23318

• This PR adds an extra 24KB to repository

• Found files with invalid states:

  • L1Trigger/DTTriggerPhase2/src/MPCleanHitsFilter.cc:
    • Added: b4067d7
    • Deleted: b96b381
  • L1Trigger/DTTriggerPhase2/interface/MPCleanHitsFilter.h:
    • Added: b4067d7
    • Deleted: b96b381

[cmsbuild]

Pull request #34025 was updated. @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05ce32/15954/summary.html
COMMIT: 1475748
CMSSW: CMSSW_12_0_X_2021-06-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34025/15954/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05ce32/15954/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2862491
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1