CTPPS validation: workaround for -O3 ASAN compilation issue #45304

dan131riley · 2024-06-25T13:32:33Z

PR description:

With -O3 optimization in the ASAN builds, Validation/CTPPS/plugins/ValidationCTPPSPlugins/CTPPSTrackDistributionPlotter.cc is failing to compile with errors of the form:

In file included from src/DataFormats/Common/interface/RefVector.h:18,
                 from src/DataFormats/ProtonReco/interface/ForwardProton.h:14,
                 from src/Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc:20:
In member function 'edm::RefVectorIterator<C, T, F>::reference edm::RefVectorIterator<C, T, F>::operator*() const [with C = std::vector<CTPPSLocalTrackLite>; T = CTPPSLocalTrackLite; F = edm::refhelper::FindUsingAdvance<std::vector<CTPPSLocalTrackLite>, CTPPSLocalTrackLite>]',
    inlined from 'virtual void CTPPSProtonReconstructionPlotter::analyze(const edm::Event&, const edm::EventSetup&)' at src/Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc:608:22:
  src/DataFormats/Common/interface/RefVectorIterator.h:49:39: error: 'this' pointer is null [-Werror=nonnull]
    49 |       return (*nestedRefVector_)[iter_];

For various reasons detailed in #44931 (comment) this has to be a compiler bug. Nevertheless, this PR provides a workaround for the compilation errors.

PR validation:

Compiles, purely technical fix, harmless.

cmsbuild · 2024-06-25T13:32:59Z

cms-bot internal usage

cmsbuild · 2024-06-25T13:39:41Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45304/40711

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45304/40711/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45304/40711/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

…ting rules)

cmsbuild · 2024-06-25T13:49:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45304/40712

This PR adds an extra 24KB to repository

cmsbuild · 2024-06-25T13:49:44Z

A new Pull Request was created by @dan131riley for master.

It involves the following packages:

Validation/CTPPS (dqm)

@antoniovagnerini, @syuvivida, @nothingface0, @rvenditti, @tjavaid, @cmsbuild can you please review it and eventually sign? Thanks.
@grzanka, @missirol this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

tjavaid · 2024-06-26T06:34:45Z

please test

cmsbuild · 2024-06-26T07:25:27Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3146a/40081/summary.html
COMMIT: 93e91e9
CMSSW: CMSSW_14_1_X_2024-06-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45304/40081/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test test_MC_23_setup had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_crosscheck had ERRORS
and more ...

RelVals

139.001

----- Begin Fatal Exception 26-Jun-2024 08:54:47 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TRawToDigi
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

140.023

----- Begin Fatal Exception 26-Jun-2024 08:54:47 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TRawToDigi
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

136.731

----- Begin Fatal Exception 26-Jun-2024 08:54:47 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TRawToDigi
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

134.801134.801_RunHLTPhy2015C/step2_RunHLTPhy2015C.log
134.805134.805_RunMET2015C/step2_RunMET2015C.log
134.802134.802_RunDoubleEG2015C/step2_RunDoubleEG2015C.log

Expand to see more relval errors ...

AddOn Tests

fastsim1

----- Begin Fatal Exception 26-Jun-2024 08:54:35 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TDigiToRaw
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 26-Jun-2024 08:54:35 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TDigiToRaw
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 26-Jun-2024 08:54:13 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TDigiToRaw
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

smuzaffar · 2024-06-26T08:27:14Z

@tjavaid , IBs are broken, lets wait for today's 11h00 IB

tjavaid · 2024-06-28T07:01:46Z

please test

cmsbuild · 2024-06-28T10:21:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3146a/40140/summary.html
COMMIT: 93e91e9
CMSSW: CMSSW_14_1_X_2024-06-27-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45304/40140/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 58 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3345088
DQMHistoTests: Total failures: 1781
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3343287
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

tjavaid · 2024-07-04T03:31:07Z

+1

spurious differences seen from unstable WF 12834.7 (open issue spurious differences in outputs of Run-3 wfs *.7 #39803 )

cmsbuild · 2024-07-04T03:31:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-07-04T18:41:09Z

please test for CMSSW_14_1_ASAN_X

cmsbuild · 2024-07-04T23:24:54Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3146a/40248/summary.html
COMMIT: 93e91e9
CMSSW: CMSSW_14_1_ASAN_X_2024-07-03-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45304/40248/install.sh to create a dev area with all the needed externals and cmssw changes.

antoniovilela · 2024-07-08T22:20:01Z

+1

CTPPS validation: workaround for -O3 ASAN compilation issue

3ca6542

cmsbuild added this to the CMSSW_14_1_X milestone Jun 25, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jun 25, 2024

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 25, 2024

formatting (one of the rare cases where I dislike our standard format…

93e91e9

…ting rules)

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 25, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 25, 2024

cmsbuild added tests-started and removed tests-pending labels Jun 26, 2024

cmsbuild added tests-rejected and removed tests-started labels Jun 26, 2024

cmsbuild added tests-started and removed tests-rejected labels Jun 28, 2024

cmsbuild removed the tests-started label Jun 28, 2024

cmsbuild added the tests-approved label Jun 28, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 4, 2024

cmsbuild added orp-approved and removed orp-pending labels Jul 8, 2024

cmsbuild merged commit 59647d3 into cms-sw:master Jul 8, 2024
17 checks passed

This was referenced Jul 9, 2024

Set c++20 as a default standard cms-sw/cmsdist#9288

Merged

Explicitly initialize bTag #45409

Merged

[GCC13] Update gcc to 13.3.0 cms-sw/cmsdist#9270

Open

[GCC13] Patch applied for c++20 cms-sw/cmsdist#9295

Merged

makortel mentioned this pull request Jul 19, 2024

Try building with -O3 by default ? #44931

Closed

makortel mentioned this pull request Aug 23, 2024

Another workaround for -O3 ASAN compilation issue in CTPPSProtonReconstructionPlotter #45786

Merged

makortel mentioned this pull request Sep 12, 2024

[ASAN_X] Compilation failure in Validation/CTPPS: 'this' pointer is null #45991

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CTPPS validation: workaround for -O3 ASAN compilation issue #45304

CTPPS validation: workaround for -O3 ASAN compilation issue #45304

dan131riley commented Jun 25, 2024

cmsbuild commented Jun 25, 2024 •

edited

Loading

cmsbuild commented Jun 25, 2024

cmsbuild commented Jun 25, 2024

cmsbuild commented Jun 25, 2024

tjavaid commented Jun 26, 2024

cmsbuild commented Jun 26, 2024

smuzaffar commented Jun 26, 2024

tjavaid commented Jun 28, 2024

cmsbuild commented Jun 28, 2024

tjavaid commented Jul 4, 2024

cmsbuild commented Jul 4, 2024

antoniovilela commented Jul 4, 2024

cmsbuild commented Jul 4, 2024

antoniovilela commented Jul 8, 2024

CTPPS validation: workaround for -O3 ASAN compilation issue #45304

CTPPS validation: workaround for -O3 ASAN compilation issue #45304

Conversation

dan131riley commented Jun 25, 2024

PR description:

PR validation:

cmsbuild commented Jun 25, 2024 • edited Loading

cmsbuild commented Jun 25, 2024

cmsbuild commented Jun 25, 2024

cmsbuild commented Jun 25, 2024

tjavaid commented Jun 26, 2024

cmsbuild commented Jun 26, 2024

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

smuzaffar commented Jun 26, 2024

tjavaid commented Jun 28, 2024

cmsbuild commented Jun 28, 2024

Comparison Summary

tjavaid commented Jul 4, 2024

cmsbuild commented Jul 4, 2024

antoniovilela commented Jul 4, 2024

cmsbuild commented Jul 4, 2024

antoniovilela commented Jul 8, 2024

cmsbuild commented Jun 25, 2024 •

edited

Loading