Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update heavy-ion eras for 2024 + add MC RelVal workflows #45307

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

mandrenguyen
Copy link
Contributor

Sets up heavy-ion eras for 2024:

  • Implements HI reco, i.e.,pp_on_PbPb type eras and their corresponding MC relval workflows (161,161.2,161.02, etc)
  • Updates the UPC eras to be based on Run3_2024, rather than just Run3, although I think for the moment they're equivalent

Note that certain sim customizations for the ZDC and HF fine-grained bit are for now just copied from the 2023 era. They are extended to the UPC era, although this era is so far only used for the reco step, not for the digi one. In case the UPC era is used for digi at some point, it's better to change this now.

The heavy-ion embedding (event overlay) workflows are not extended to 2024 yet. This will be done in a subsequent PR.

No backport will be needed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 26, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor Author

test parameters:

  • workflows = 161, 161.02, 161.03, 161.1, 180, 180.1, 181, 181.1, 142.901, 142.902

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45307/40717

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

  • Configuration/Eras (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • SimCalorimetry/HcalTrigPrimProducers (l1)
  • SimG4Core/Application (simulation)

@srimanob, @subirsarkar, @aloeliger, @civanch, @rappoccio, @fabiocos, @davidlange6, @kskovpen, @mdhildreth, @miquork, @cmsbuild, @AdrianoDee, @sunilUIET, @antoniovilela, @epalencia can you please review it and eventually sign? Thanks.
@missirol, @VinInn, @rovere, @mmusich, @GiacomoSguazzoni, @AnnikaStein, @VourMa, @dgulhan, @slomeo, @bsunanda, @fabiocos, @Martin-Grunewald, @sameasy, @abdoulline, @JanFSchulte, @mtosi, @makortel, @felicepantaleo this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0d7d8/40078/summary.html
COMMIT: a0ea6a0
CMSSW: CMSSW_14_1_X_2024-06-25-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45307/40078/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test test_MC_22_crosscheck had ERRORS
---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_22_setup had ERRORS
and more ...

RelVals

----- Begin Fatal Exception 26-Jun-2024 04:57:39 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TRawToDigi
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-Jun-2024 04:57:39 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TRawToDigi
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-Jun-2024 04:57:39 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TRawToDigi
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 134.801134.801_RunHLTPhy2015C/step2_RunHLTPhy2015C.log
  • 134.802134.802_RunDoubleEG2015C/step2_RunDoubleEG2015C.log
  • 134.803134.803_RunDoubleMuon2015C/step2_RunDoubleMuon2015C.log
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 26-Jun-2024 04:55:28 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TDigiToRaw
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-Jun-2024 04:55:29 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TDigiToRaw
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 26-Jun-2024 04:55:03 CEST-----------------------
An exception of category 'PluginLibraryLoadError' occurred while
   [0] Constructing the EventProcessor
   [1] While attempting to load plugin L1TDigiToRaw
Exception Message:
unable to load /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so because /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02843/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_1_X_2024-06-25-2300/lib/el8_amd64_gcc12/poisoned/plugin-poisoned-EventFilterL1TRawToDigiAuto.so: cannot open shared object file: No such file or directory
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@mandrenguyen
Copy link
Contributor Author

mandrenguyen commented Jun 26, 2024

please test
These tests seem to run file locally. I'm not sure what this poisoned plugin error mentioned in the logs is about.
For lack of a better idea, I'm just gonna try to the tests again and see if this was transient.
If anyone has some insight please enlighten me.

@mmusich
Copy link
Contributor

mmusich commented Jun 26, 2024

For lack of a better idea, I'm just gonna try to the tests again and see if this was transient.

this issue was caused by a severely broken IB CMSSW_14_1_X_2024-06-25-2300 due to this PR. See discussion there for a rationale. It was fixed in CMSSW_14_1_X_2024-06-26-1200

@civanch
Copy link
Contributor

civanch commented Jul 2, 2024

+1

@mandrenguyen
Copy link
Contributor Author

ping @cms-sw/pdmv-l2 @cms-sw/upgrade-l2

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2024

+Upgrade

@srimanob
Copy link
Contributor

srimanob commented Jul 8, 2024

@cmsbuild please test

Retrigger the test after 2 weeks, before merging.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0d7d8/40287/summary.html
COMMIT: de91238
CMSSW: CMSSW_14_1_X_2024-07-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45307/40287/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345088
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345062
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@AdrianoDee
Copy link
Contributor

+pdmv

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 702ffcd into cms-sw:master Jul 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants