-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TICLv5 : Superclustering DNN #45333
base: master
Are you sure you want to change the base?
TICLv5 : Superclustering DNN #45333
Conversation
cms-bot internal usage |
A new Pull Request was created by @tcuisset for master. It involves the following packages:
@AdrianoDee, @antoniovagnerini, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @mdhildreth, @miquork, @nothingface0, @rappoccio, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild please test |
-1 Failed Tests: RelVals
RelVals
|
@cmsbuild please test with cms-data/RecoHGCal-TICL#5 |
-1 Failed Tests: RelVals
RelVals
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40167/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here:
Comparison SummarySummary:
|
test parameters:
|
Co-authored-by: Shamik Ghosh <[email protected]>
188e7a5
to
378b065
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45333/40779
|
Pull request #45333 was updated. @AdrianoDee, @antoniovagnerini, @antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @jfernan2, @kskovpen, @mandrenguyen, @mdhildreth, @miquork, @nothingface0, @rappoccio, @rvenditti, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please check and sign again. |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1a85e/40183/summary.html
Comparison SummarySummary:
|
enable profiling |
please test |
enable none |
PR description:
This PR brings a new electron superclustering setup for TICLv5. Superclusters can be built either using a DNN or the Mustache algorithm.
Changes :
Adds three process modifiers to choose between old PF-based Mustache superclustering, new TICL-based Mustache, and DNN-based superclustering.
No changes are expected to workflows that do not enable ticl_v5 modifier (off by default). For ticl_v5 workflows changes in electron reconstruction are expected.
Presentation : TICL meeting
This PR depends on cms-data : cms-data/RecoHGCal-TICL#5
PR validation:
Tested using runTheMatrix workflows :
and also 29846.204,29846.205,29891.203,29891.204,29891.205