Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase precision of two shower shape observables for Hgg analysis #46800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlessandroTarabini
Copy link

@AlessandroTarabini AlessandroTarabini commented Nov 26, 2024

PR description:

We would like to increase the precision (from 8 to 10) of two shower shape observables for Hgg analyses (pfChargedIso and hoe) due to the observation of spikes in the distributions [slide10]. This issue was already noticed in the past for other observables, which led to the decision to increase the precision of these floats to 10 [merged PR]

PR validation:

The change is trivial

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This change should be included in NanoAODv15, so it should be back ported to the corresponding CMSSW version

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AlessandroTarabini for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @ftorrresd, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Nov 26, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Nov 26, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-484ac6/43093/summary.html
COMMIT: bc94e15
CMSSW: CMSSW_15_0_X_2024-11-26-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46800/43093/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1065 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 21
  • DQMHistoTests: Total histograms compared: 74922
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 74893
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 20 files compared)
  • Checked 102 log files, 58 edm output root files, 21 DQM output files
  • TriggerResults: no differences found

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.001 3.076 3.074 0.002 ( +0.0% ) 6.06 6.38 -4.9% 2.513 2.508
2500.002 3.192 3.191 0.000 ( +0.0% ) 5.45 5.72 -4.7% 2.947 2.936
2500.003 3.132 3.132 0.001 ( +0.0% ) 5.76 5.98 -3.6% 2.934 2.916
2500.011 1.644 1.643 0.001 ( +0.0% ) 9.39 10.06 -6.7% 2.605 2.605
2500.012 2.184 2.183 0.001 ( +0.0% ) 5.70 5.95 -4.1% 2.792 2.794
2500.013 1.999 1.998 0.001 ( +0.1% ) 7.97 8.24 -3.3% 2.694 2.699
2500.021 0.022 0.022 0.000 ( +0.0% ) 1.87 2.08 -10.2% 2.585 2.577
2500.022 0.022 0.022 0.000 ( +0.0% ) 1.78 2.01 -11.7% 2.568 2.577
2500.023 0.022 0.022 0.000 ( +0.0% ) 1.79 1.90 -6.0% 2.427 2.433
2500.024 0.022 0.022 0.000 ( +0.0% ) 1.44 1.57 -8.8% 2.670 2.678
2500.031 0.035 0.035 0.000 ( +0.0% ) 1.68 1.77 -5.3% 2.632 2.622
2500.032 0.036 0.036 0.000 ( +0.0% ) 1.67 1.82 -8.4% 2.588 2.588
2500.033 0.037 0.037 0.000 ( +0.0% ) 1.55 1.74 -11.1% 2.670 2.669
2500.034 0.036 0.036 0.000 ( +0.0% ) 1.59 1.72 -7.9% 2.653 2.654
2500.101 2.808 2.807 0.001 ( +0.0% ) 14.63 16.69 -12.3% 2.614 2.605
2500.111 1.462 1.461 0.001 ( +0.0% ) 27.54 32.51 -15.3% 2.306 2.307
2500.112 1.882 1.881 0.001 ( +0.0% ) 23.17 27.00 -14.2% 2.377 2.378
2500.131 0.747 0.747 0.000 ( +0.0% ) 32.89 37.93 -13.3% 1.464 1.496
2500.201 2.637 2.636 0.001 ( +0.0% ) 12.54 13.41 -6.5% 2.176 2.168
2500.211 1.805 1.804 0.001 ( +0.0% ) 23.11 27.82 -17.0% 2.378 2.378
2500.212 2.201 2.200 0.001 ( +0.0% ) 20.15 23.43 -14.0% 2.458 2.463
2500.221 2.036 2.036 0.000 ( +0.0% ) 12.74 14.77 -13.8% 2.075 2.080
2500.222 3.438 3.437 0.001 ( +0.0% ) 11.74 13.69 -14.2% 2.180 2.185
2500.223 9.404 9.403 0.001 ( +0.0% ) 3.65 4.30 -15.0% 2.251 2.254
2500.224 6.260 6.259 0.001 ( +0.0% ) 1.33 1.40 -5.1% 2.196 2.243
2500.225 6.307 6.306 0.001 ( +0.0% ) 1.24 1.29 -4.3% 2.397 2.455
2500.226 3.132 3.131 0.001 ( +0.0% ) 11.44 14.33 -20.2% 2.174 2.178
2500.227 1.437 1.437 0.000 ( +0.0% ) 21.77 24.25 -10.2% 1.419 1.432
2500.231 1.454 1.454 0.000 ( +0.0% ) 19.57 23.75 -17.6% 1.984 2.263
2500.232 2.460 2.459 0.001 ( +0.0% ) 17.92 21.89 -18.1% 2.085 2.372
2500.233 4.952 4.952 0.001 ( +0.0% ) 5.85 6.19 -5.6% 2.437 2.434
2500.234 3.839 3.838 0.001 ( +0.0% ) 1.74 1.77 -1.7% 2.158 2.393
2500.235 3.870 3.869 0.001 ( +0.0% ) 1.64 1.67 -1.5% 2.345 2.596
2500.236 2.250 2.249 0.001 ( +0.0% ) 21.49 23.71 -9.4% 2.366 2.367
2500.237 1.016 1.016 0.000 ( +0.0% ) 34.36 35.09 -2.1% 1.433 1.440
2500.241 9.404 9.404 0.000 ( +0.0% ) 8.49 7.92 +7.2% 1.892 1.891
2500.242 10.331 10.331 0.000 ( +0.0% ) 1.62 1.66 -2.4% 1.690 1.690
2500.243 2.712 2.712 0.000 ( +0.0% ) 16.42 15.69 +4.7% 1.046 1.047
2500.244 485.976 485.976 0.000 ( +0.0% ) 1.12 1.14 -2.0% 1.660 1.655
2500.245 823.202 823.202 0.000 ( +0.0% ) 1.49 1.51 -1.5% 1.661 1.650
2500.901 1.777 1.777 0.000 ( +0.0% ) 43.60 46.18 -5.6% 1.407 1.406
2500.902 1.627 1.627 0.000 ( +0.0% ) 48.66 47.98 +1.4% 1.303 1.302
2500.911 14.041 14.041 0.000 ( +0.0% ) 9.02 8.00 +12.8% 1.066 1.067
2500.912 0.438 0.171 0.267 ( +156.1% ) 1.92 4.33 -55.7% 0.836 0.831
2500.913 0.110 0.110 0.000 ( +0.0% ) 2.66 2.58 +3.0% 0.836 0.834

@hqucms
Copy link
Contributor

hqucms commented Nov 26, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants